Closed Bug 1432737 Opened 7 years ago Closed 6 years ago

Add the 'esr' string to MOZ_APP_VERSION_DISPLAY

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox-esr6061+ fixed, firefox59 unaffected, firefox60 unaffected, firefox61 unaffected, firefox62 unaffected)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox-esr60 61+ fixed
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected

People

(Reporter: Sylvestre, Assigned: Callek)

References

Details

Attachments

(1 file)

Bug 1432737 - No longer strip 'esr' from ship-it version when comparing with esr display version. r=rail
(deleted), text/x-phabricator-request
rail
: review+
Details
Seems that it would help the life of a few people: https://bugzilla.mozilla.org/show_bug.cgi?id=1386076#c16 I don't have any issue and it should be easy to do (and no/limited impact)! But not sure we want to uplift that 52...
Todo, link this to a bug/issue on treescript https://github.com/mozilla-releng/treescript/ . see-also https://github.com/mozilla-releng/treescript/blob/master/treescript/test/test_versionmanip.py#L23
Flags: needinfo?(bugspam.Callek)
Product: Core → Firefox Build System
Landed at Callek's request. https://hg.mozilla.org/releases/mozilla-esr60/rev/34474b4c614bd46ebe87f5b104a1557497522f6f
Assignee: sledru → ryanvm
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59: --- → unaffected
status-firefox60: affected → unaffected
status-firefox61: --- → unaffected
status-firefox-esr60: --- → fixed
tracking-firefox-esr60: --- → 60+
Flags: needinfo?(bugspam.Callek)
Resolution: --- → FIXED
Backed out because it breaks ship-it. https://hg.mozilla.org/releases/mozilla-esr60/rev/565d653b243a4a9dcf2035e17b876733ba02d58e
Status: RESOLVED → REOPENED
status-firefox-esr60: fixed → affected
Resolution: FIXED → ---
Assignee: ryanvm → bugspam.Callek
status-firefox62: --- → unaffected
tracking-firefox-esr60: 60+ → 61+
for - Add the 'esr' string to MOZ_APP_VERSION_DISPLAY
Comment on attachment 8974076 [details] Bug 1432737 - No longer strip 'esr' from ship-it version when comparing with esr display version. r=rail Rail Aliiev [:rail] ⌚️ET has approved the revision. https://phabricator.services.mozilla.com/D1215
Attachment #8974076 - Flags: review+
https://hg.mozilla.org/build/tools/rev/82ac339f0643eeae08c477a518e72cad5d21bc81 Backed out changeset c2297c18a0ff, Bug 1432737 - No longer strip 'esr' from ship-it version when comparing with esr display version, r=backout
Whiteboard: checkin-needed-esr60
I've updated bm85:/builds/releaserunner3/tools/ from 54446ea4e817 to 316bb57741ab, and restarted releaserunner, so that this is ready for 60.1.0esr next week. Also stage at bm83:/builds/releaserunner3/tools/ from be42ba326d72 (local!) to 316bb57741ab.
60.1 built with this https://hg.mozilla.org/releases/mozilla-esr60/file/4ad4c31db9b1526aab8641be98fec8e0d63a4a7e/browser/config/version_display.txt
Status: REOPENED → RESOLVED
Closed: 7 years ago → 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: