Closed
Bug 1432842
Opened 7 years ago
Closed 7 years ago
Update Debugger Frontend v10
Categories
(DevTools :: Debugger, enhancement)
DevTools
Debugger
Tracking
(firefox60 fixed)
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
Details
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
jdescottes
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jdescottes
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jlaster
Blocks: debugger-bundle-updates
Assignee | ||
Comment 1•7 years ago
|
||
Here is an early try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c82be14e245f86c7ec820f14627d7a2b9338fd9
- The patch seems reasonable. about 7K +- lines because we're uprgrading reps.
- We should be careful to not overwrite Gabe's photon changes in debugger.css
Assignee | ||
Comment 2•7 years ago
|
||
here's a new try run w/ the fixes to the mochitests (needed to include another commit w/ a reps bump)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fda59e415cdbd70f86f2249acdc03c510d2156d7
Assignee | ||
Comment 3•7 years ago
|
||
Assignee | ||
Comment 4•7 years ago
|
||
okay, we've got a failure in the optimized builds... not a big deal. will investigate tomorrow
Comment 5•7 years ago
|
||
jlast: FYI the release includes a huge 10MB webpack-stats.html file. Make sure to remove.
Flags: needinfo?(jlaster)
Comment 6•7 years ago
|
||
Two issues here:
1/ we regressed the panel.isPaused method, it's now missing!
2/ the browser toolbox test injects in the browser toolbox process:
- a new-debugger test
- the new-debugger head.js
But it doesn't have access to shared-head. And it just happens that waitForPaused in new-debugger head.js was modified to rely on waitUntil, which comes from shared-head. For now I suggest just importing waitUntil, without trying to inject the whole shared-head for this test.
Try run with fixes for both issues:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=103261a0ce666d21761bc7c65ad933c36bd1d662
Comment 7•7 years ago
|
||
PR opened for the isPaused method, as I couldn't find it anywhere on the repo. https://github.com/devtools-html/debugger.html/pull/5194
Comment 8•7 years ago
|
||
If try is green with this, I would suggest to make a new release including isPaused and to keep my toolbox test patch separated.
Assignee | ||
Comment 9•7 years ago
|
||
Flags: needinfo?(jlaster)
Attachment #8945437 -
Flags: review?(jdescottes)
Assignee | ||
Comment 10•7 years ago
|
||
Comment 11•7 years ago
|
||
Comment on attachment 8945437 [details] [diff] [review]
release-10.patch
Review of attachment 8945437 [details] [diff] [review]:
-----------------------------------------------------------------
Needs a valid commit, and consistency with the versioning scheme.
::: devtools/client/debugger/new/README.mozilla
@@ +1,4 @@
> This is the debugger.html project output.
> See https://github.com/devtools-html/debugger.html
>
> +Version 10
10.0 please
@@ +1,5 @@
> This is the debugger.html project output.
> See https://github.com/devtools-html/debugger.html
>
> +Version 10
> +Commit: https://github.com/devtools-html/debugger.html/commit/a6351244d92145b
https://github.com/devtools-html/debugger.html/commit/a6351244d92145b -> 404
Assignee | ||
Comment 12•7 years ago
|
||
Attachment #8945437 -
Attachment is obsolete: true
Attachment #8945437 -
Flags: review?(jdescottes)
Attachment #8945488 -
Flags: review?(jdescottes)
Assignee | ||
Comment 13•7 years ago
|
||
Attachment #8945488 -
Attachment is obsolete: true
Attachment #8945488 -
Flags: review?(jdescottes)
Attachment #8945562 -
Flags: review?(jdescottes)
Comment 15•7 years ago
|
||
Comment on attachment 8945562 [details] [diff] [review]
release-10-2.patch
Review of attachment 8945562 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. Last try push with both patches: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f8a9c3367b17dc1d68ed8e708ec1157f2716886
Attachment #8945562 -
Flags: review?(jdescottes) → review+
Comment 16•7 years ago
|
||
As inbound is currently closed, adding checkin-needed.
Both patches attached here should land together, the order doesn't matter. Thanks!
Keywords: checkin-needed
Comment 17•7 years ago
|
||
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aba21dd5668b
Update Debugger Frontend v10. r=jdescottes
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3d2757a5343
duplicate waitUntil() in browser toolbox test;r=jlast
Keywords: checkin-needed
Comment 18•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/aba21dd5668b
https://hg.mozilla.org/mozilla-central/rev/c3d2757a5343
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•