Copy-pasting multiple click-selected table rows to a WYSWYG editor loses linebreaks
Categories
(Core :: DOM: Serializers, defect, P2)
Tracking
()
People
(Reporter: matteo.sindona, Assigned: mbrodesser-Igalia)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(7 files, 1 obsolete file)
Comment 1•7 years ago
|
||
Reporter | ||
Comment 2•7 years ago
|
||
Reporter | ||
Comment 3•7 years ago
|
||
Comment 4•7 years ago
|
||
Reporter | ||
Comment 5•7 years ago
|
||
Reporter | ||
Comment 6•7 years ago
|
||
Reporter | ||
Comment 7•7 years ago
|
||
Reporter | ||
Comment 8•7 years ago
|
||
Comment 9•7 years ago
|
||
Reporter | ||
Comment 10•7 years ago
|
||
Reporter | ||
Comment 13•7 years ago
|
||
Reporter | ||
Comment 19•7 years ago
|
||
Reporter | ||
Comment 20•7 years ago
|
||
Comment 21•7 years ago
|
||
Reporter | ||
Comment 22•7 years ago
|
||
Reporter | ||
Comment 25•7 years ago
|
||
Reporter | ||
Comment 26•7 years ago
|
||
Reporter | ||
Comment 27•7 years ago
|
||
Updated•7 years ago
|
Updated•6 years ago
|
Updated•5 years ago
|
Reporter | ||
Comment 29•5 years ago
|
||
Hello,
is there any way to have this fixed ?
Thank you!
Comment 30•5 years ago
|
||
The workaround is to Ctrl-V to a LO Calc (Gdocs, Excel) and then to copy from it as a formatted table.
Reporter | ||
Comment 31•5 years ago
|
||
Yeah, I am aware of that workaround. Another workaround is to select the tables with the mouse WITHOUT ctrl selection. But would it be possible to fix the bug in the future so we can still copy tables using ctrl like we were doing before Firefox 58.0 ?
Thanks!
Comment 32•5 years ago
|
||
I'm ready to donate 25 € to Mozilla when fixing this bug.
Comment 33•5 years ago
|
||
Can you post a publicly accessible table where this problems reproduces? The link (https://data.fis-ski.com/dynamic/results.html?sector=NK&raceid=2189) in comment 2 now seems to use divs.
Reporter | ||
Comment 34•5 years ago
|
||
Hello Tom, you are right, that website changed its table format in the while.
Please use this link to copy the table instead: https://dataride.uci.ch/Results/iframe/EventResults/220062?competitionId=59800&disciplineId=7
It is also important for me this problem to be fixed (I can't use Firefox with this bug) so I would be very grateful if you guys can fix it in the next release!
Thank you very much!
Assignee | ||
Comment 35•5 years ago
|
||
I've tried to reproduce this on Ubuntu 18.04 with Firefox 75.0 (64-bit) and didn't succeed. That is, the problem didn't occur.
I've used the link of c34 as input with CTRL and click selecting two consecutive rows.
Used Ctrl+c and Ctrl+v to paste the selected rows to https://froala.com/wysiwyg-editor/inline/ (because the login to the forum account provided above doesn't work).
Matteo, does the issue still occur for you? If so, does it also occur when pasting to https://froala.com/wysiwyg-editor/inline/? If not, can you please provide detailed steps to reproduce the issue nowadays?
Reporter | ||
Comment 36•5 years ago
|
||
Hello Mirko,
thank you for your reply! Unfortunately, I still have the problem with Firefox 75.0 (64-bit), using Windows 10.
I also do not have the problem with froala link you posted, but I still have it on my website.
I have re-activated the test account so you can try yourself. Go here: https://results.totallympics.com/forum.php?mod=post&action=newthread&fid=71
And login with
Username "test"
Password "test123"
Copying and pasting using ctrl+c ctrl+v should give you the problem, unless something changes between Windows and Ubuntu.
But since on froala the problem does not occur, maybe I have to change some settings on my website?
Thank you and best regards,
Matteo
Assignee | ||
Comment 37•5 years ago
|
||
Thanks for testing again and for re-activating the account.
With that account, the issue is reproducible on Ubuntu. Before pasting to the WYSIWYG editor, one needs to switch to advanced mode and uncheck the "Code" checkbox.
When selecting multiple consecutive rows (without pressing Ctrl), pasting works.
As Table-Click-Selection with Ctrl is a Firefox only feature, the issue requires more analysis to determine whether it's a bug in the forum of in Firefox. Both is possible.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Reporter | ||
Comment 38•5 years ago
|
||
Hello Mirko,
yeah, sorry I forgot to tell you to click on "Code" button before pasting the text, but you found it out by yourself.
I can edit any file of my website so if you have any suggestion on what should I do to have this problem fixed that would be amazing!
Thank you,
Matteo
Assignee | ||
Comment 39•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 40•5 years ago
|
||
Assignee | ||
Comment 41•5 years ago
|
||
The proposal of c23 seems reasonable. However, in order to avoid regressions understanding why the fix mentioned there broke the behavior seems the safer way forward.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 42•5 years ago
|
||
Found the cause of the regression: mCommonInclusiveAncestors
is used after EncodeToString
is called, but mCommonInclusiveAncestors
isn't updated anymore as it was done previously.
Reporter | ||
Comment 43•5 years ago
|
||
Hello Mirko,
nice to hear that. Any chance this can be fixed in the future versions of Firefox ?
Thank you!
Assignee | ||
Comment 44•5 years ago
|
||
Assignee | ||
Comment 45•5 years ago
|
||
Check when copy-pasting multiple click-selected table rows, the
clipboard's "text/_moz_htmlcontext" flavor doesn't contain a <tr>
.
Depends on D71980
Assignee | ||
Comment 46•5 years ago
|
||
This reverts a previously introduced regression. See the Bugzilla
comments of this bug.
The key consequence of this is change is that copy-pasting multiple
click-selected table rows now works again for some applications (and
shouldn't be broken for others). That's because the clipboard flavor
"text/_moz_htmlcontext" doesn't contain a superfluous "<tr>" anymore.
The fix could presumably be more elegant, but it would be hard to ensure
no other applications relying on the old behavior break.
Depends on D71981
Assignee | ||
Comment 47•5 years ago
|
||
(In reply to matteo.sindona from comment #43)
Hello Mirko,
nice to hear that. Any chance this can be fixed in the future versions of Firefox ?
Thank you!
I can't promise anything, but perhaps the fix can be merged to Nightly soon. This issue will track the status.
Comment 48•5 years ago
|
||
Comment 49•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a596f2de0950
https://hg.mozilla.org/mozilla-central/rev/7e93722dbf4d
https://hg.mozilla.org/mozilla-central/rev/f32067e1ce26
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Description
•