Closed
Bug 1433081
Opened 7 years ago
Closed 6 years ago
[Wayland] Enable to specify GL provider at build time with "--with-gl-provider"
Categories
(Core :: Graphics: CanvasWebGL, enhancement, P3)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
WONTFIX
Tracking | Status | |
---|---|---|
firefox60 | --- | affected |
People
(Reporter: stransky, Assigned: stransky)
References
Details
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/x-review-board-request
|
Details |
--with-gl-provider option is broken right now and we need that to provide Wayland/EGL enabled build.
Assignee | ||
Comment 1•7 years ago
|
||
WIP patch
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
Comment on attachment 8946797 [details]
Bug 1433081 - Don't try to build different GL backends when MOZ_GL_PROVIDER is set,
punting to jgilbert
Attachment #8946797 -
Flags: review?(jmuizelaar) → review?(jgilbert)
Assignee | ||
Comment 5•7 years ago
|
||
We don't depend on Wayland any more as Bug 1434574 lands. But it's really easy to to make gl-provider work again.
No longer blocks: wayland
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8946797 [details]
Bug 1433081 - Don't try to build different GL backends when MOZ_GL_PROVIDER is set,
https://reviewboard.mozilla.org/r/216718/#review224052
::: gfx/gl/GLContextProvider.h:29
(Diff revision 1)
> // Null is always there
> #define GL_CONTEXT_PROVIDER_NAME GLContextProviderNull
> #include "GLContextProviderImpl.h"
> #undef GL_CONTEXT_PROVIDER_NAME
>
> +#if !defined(MOZ_GL_PROVIDER)
#ifndef
::: gfx/gl/GLContextProvider.h:69
(Diff revision 1)
> #ifndef GL_CONTEXT_PROVIDER_DEFAULT
> #define GL_CONTEXT_PROVIDER_DEFAULT GLContextProviderEAGL
> #endif
> #endif
>
> +#else //defined(MOZ_GL_PROVIDER)
space after //
::: gfx/gl/GLContextProvider.h:72
(Diff revision 1)
> #endif
>
> +#else //defined(MOZ_GL_PROVIDER)
> +
> #ifdef MOZ_GL_PROVIDER
> #define GL_CONTEXT_PROVIDER_NAME MOZ_GL_PROVIDER
Just move this whole block above the other blocks, so we hit MOZ_GL_PROVIDER first.
Attachment #8946797 -
Flags: review?(jgilbert) → review-
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8946797 [details]
Bug 1433081 - Don't try to build different GL backends when MOZ_GL_PROVIDER is set,
https://reviewboard.mozilla.org/r/216718/#review224052
> #ifndef
I actually used the leading "#ifdef MOZ_GL_PROVIDER" here.
Assignee | ||
Comment 9•6 years ago
|
||
I don't think we need that now.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Updated•6 years ago
|
Attachment #8946797 -
Flags: review?(jgilbert)
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•