shrirang khanzode Reporter
	Description • 23 years ago

mac only, 0509 branch build.

go to the url.

try to type in the textbox...click on submit.
nothing happens. :(

	shrirang khanzode Reporter
	Comment 1 • 23 years ago

peterl..

	Peter Lubczynski
	Comment 2 • 23 years ago

...one line fix on the way, testing in Carbon now...

	Peter Lubczynski
	Comment 3 • 23 years ago

This apprently looks like it was caused by bug 84681. This patch removes one of
the hacked lines inserted from that bug.

	av (gone)
	Comment 4 • 23 years ago

Does not it regress back to that bug now?

	Peter Lubczynski
	Comment 5 • 23 years ago

oddly, no! I tested and it and works in both Classic/Carbon. 

That's an old bug and our event system keeps playing tricks on me.

	rubydoo123
	Comment 6 • 23 years ago

adding ADT marker and milestone

	scottputterman
	Comment 7 • 23 years ago

Please get a review and super review for this.

	Jaime Rodriguez, Jr.
	Comment 8 • 23 years ago

Removing adt1.0.0, because the patch does not have r/sr=. Pls get the reviews,
and land this on the trunk, then add adt1.0.0 keyword.

	Peter Lubczynski
	Comment 10 • 23 years ago

This bug has become more serious. It seems QT and Flash are both effected -- no
keyboard events are working on any full-page plugins on Mac.

This does not regress bug 84681. All full-page plugins on Mac are working
correctly after this patch and this patch is in a #ifdef XP_MAC section.

	av (gone)
	Comment 11 • 23 years ago

Comment on attachment 82977 [details] [diff] [review]
1-line patch

Fine with me. Peter also conducted massive testing with other plugins focussing
on key input. r=av

	Marc Attinasi
	Comment 12 • 23 years ago

Comment on attachment 82977 [details] [diff] [review]
1-line patch

sr=attinasi - it would be nice to know why this stopped working though ;-)

	Peter Lubczynski
	Comment 13 • 23 years ago

Full-page plugins are very sensitve to event changes because they live at the
document viewer level. In one of the many changes to events in the past year,
plugin code is no longer incorrectly recieving double key events (wallpapered by
bug 84681) but now correctly recieving single events.

The code around this is still pretty messy so I've opened bug 144876 to clean up.

	Peter Lubczynski
	Comment 14 • 23 years ago

patch on trunk, marking FIXED.

	rubydoo123
	Comment 15 • 23 years ago

testing on OSX with the trunk build from 2002051608 functions correctly with the
attached test case from comment #9

	Peter Lubczynski
	Comment 16 • 23 years ago

Quicktime testcase:
http://starwars.apple.com/ep2/breathing/img/sw_ctp_240.mov
Without the patch, the space bar does not start/stop the movie.

Also note that there is no Acrobat 5 for Carbon.

	scottputterman
	Comment 17 • 23 years ago

adding adt1.0.0+.  Please get drivers approval and then check into the 1.0 branch.

	Dawn Endico
	Comment 18 • 23 years ago

Comment on attachment 82977 [details] [diff] [review]
1-line patch

a=chofmann,brendan,etc

need to check this in asap for rc3. -thanks

	Peter Lubczynski
	Comment 19 • 23 years ago

patch on branch

thanks everyone!

	shrirang khanzode Reporter
	Comment 20 • 23 years ago

yes, this works now on 0521 brnch on osx and 9.2. checked out flash , qktime and 
acrobat tests.

	Jaime Rodriguez, Jr.
	Comment 21 • 23 years ago

Removing "+" from Status Whiteboard, as the bugs are plussed by the ADT in the
Keywords.

	bmartin
	Comment 22 • 22 years ago

Marking this Verified Fixed
Testing against Mac OSX Mozilla 2003050803 trunk

Tested keyboard events with Full Screen QuickTime plugin successfully:
Go to: http://www.apple.com/trailers/disney/finding_nemo/trailer/ choose Full
Screen option

Tested keyboard events against Flash testcase in comment #9