Closed
Bug 1433230
Opened 7 years ago
Closed 7 years ago
Add recent downloads to Highlights
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
People
(Reporter: Mardak, Assigned: ursula)
References
(Blocks 1 open bug, )
Details
(Keywords: uiwanted, Whiteboard: [strings landed])
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
From https://github.com/mozilla/activity-stream/issues/3535
Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1354536 is reusing Activity Stream's Highlights queries to populate "Recent Activity" feature in the Library panel. The bug was originally filed as including downloaded items.
As we currently don't have downloads in Highlights, neither feature shows downloads.
Updated•7 years ago
|
Iteration: 61.1 - Mar 26 → ---
Updated•7 years ago
|
Iteration: --- → 61.1 - Mar 26
Updated•7 years ago
|
Assignee: nobody → usarracini
Updated•7 years ago
|
Flags: needinfo?(amlee)
Reporter | ||
Updated•7 years ago
|
Assignee | ||
Comment 1•7 years ago
|
||
uiwanted:
1. available context menu options for downloaded items
2. what happens when clicking on a downloaded item
3. what is the preview image for downloaded item
4. what is the description or tile of downloaded item
5. icons + strings
6. downloaded items since when? only the current session?
Reporter | ||
Updated•7 years ago
|
Priority: P3 → P1
Assignee | ||
Comment 2•7 years ago
|
||
Invision designs: https://mozilla.invisionapp.com/share/VGGD0F4XR82#/screens
Comment 3•7 years ago
|
||
@Amy, will the "Show In Finder" string be used on Windows and Linux too?
Assignee | ||
Comment 4•7 years ago
|
||
@Ciprian, we're going to have platform specific strings :)
@Amy, there are still some outstanding questions around the behaviour of downloaded items in highlights:
1. Are we re-using the same frecency (5 days) for downloaded items to show up
2. What is the priority for Highlights now? As in, what's more important to show, Pocket vs Downloads vs Bookmarks vs History items
3. When we add/delete/change a downloaded item (at a system level - not just "dismiss" that card on newtab), how soon should that be reflected in Highlights? As soon as it happens? 5 minutes on the next update cycle?
Comment 5•7 years ago
|
||
Hi Bryan,
Can you provide some feed for the above questions? Thanks
Flags: needinfo?(amlee) → needinfo?(bbell)
Comment 6•7 years ago
|
||
(In reply to Ciprian Muresan [:cmuresan], Desktop Engineering QA, :steve from comment #3)
> @Amy, will the "Show In Finder" string be used on Windows and Linux too?
The string for Windows/Linux is "Open Containing Folder"
Comment 7•7 years ago
|
||
Trello card/Updated Spec https://trello.com/c/7AJYeOmj/182-recent-downloads-in-highlights
Updated•7 years ago
|
Iteration: 61.1 - Mar 26 → 61.2 - Apr 9
Updated•7 years ago
|
Whiteboard: [strings needed]
Updated•7 years ago
|
Updated•7 years ago
|
Comment 8•7 years ago
|
||
Updated•7 years ago
|
Iteration: 61.2 - Apr 9 → 61.3 - Apr 23
Updated•7 years ago
|
Iteration: 61.3 - Apr 23 → ---
status-firefox61:
--- → wontfix
Assignee | ||
Updated•7 years ago
|
Iteration: --- → 61.3 - Apr 23
Comment 9•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/e87a190e15becece8b98a3f49ccf55ffbe9baa1a
feat(highlights): Lazily add DownloadsManager view to handle recent downloads (#4076)
Fix Bug 1433230 - Add recent downloads to Highlights
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 10•7 years ago
|
||
Target Milestone: --- → Firefox 61
Reporter | ||
Comment 11•7 years ago
|
||
Strings landed for localization in https://github.com/mozilla/activity-stream-l10n/pull/15
Whiteboard: [strings needed] → [strings landed]
Comment 12•7 years ago
|
||
Build ID 20180422223305
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
I have verified that the issue is no longer reproducible on the latest Nightly build on Windows 10 x64, Mac 10.13.3 and Arch Linux x64. The most recent downloaded item is now displayed on the New Tab page.
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•