Closed
Bug 1433422
Opened 7 years ago
Closed 7 years ago
WebDriver:ElementSendKeys does not append to a textual form control with existing value
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox-esr52 unaffected, firefox58 unaffected, firefox59 fixed, firefox60 fixed)
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox58 | --- | unaffected |
firefox59 | --- | fixed |
firefox60 | --- | fixed |
People
(Reporter: barancev, Assigned: ato)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(4 files, 4 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36
Steps to reproduce:
Firefox Nightly 60.0a1 (2018-01-26) (64-bit)
Regression issue, yesterday's Nigtly was OK.
WebDriver driver = new FirefoxDriver();
driver.get("https://output.jsbin.com/neserun");
WebElement input = driver.findElement(By.name("test"));
assertEquals("test", input.getAttribute("value"));
input.sendKeys("123");
assertEquals("test123", input.getAttribute("value"));
it fails with
Expected: test123
Actual: 123test
Actual results:
The text should be appended to the existing value.
Expected results:
It is added in the beginning instead.
Updated•7 years ago
|
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Comment 2•7 years ago
|
||
This is a regression from bug 1432864
Status: RESOLVED → REOPENED
Ever confirmed: true
Flags: needinfo?(ato)
Resolution: DUPLICATE → ---
Updated•7 years ago
|
Blocks: 1432864
status-firefox59:
--- → unaffected
status-firefox60:
--- → affected
Keywords: regression
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(ato)
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Summary: sendKeys should append text in an input with existing value → WebDriver:ElementSendKeys does not append to a textual form control with existing value
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8945811 [details]
Bug 1433422 - Show full pytest failure logs.
https://reviewboard.mozilla.org/r/215904/#review221724
I guess I worry it coudl produce too much output for expected failures, but we could try this and see how it goes.
Attachment #8945811 -
Flags: review?(james) → review+
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8945812 [details]
Bug 1433422 - Move caret after focussing element.
https://reviewboard.mozilla.org/r/215906/#review221954
Attachment #8945812 -
Flags: review?(dburns) → review+
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8945813 [details]
Bug 1433422 - Fix interaction.moveCaretToEnd element conditions.
https://reviewboard.mozilla.org/r/215908/#review221956
Attachment #8945813 -
Flags: review?(dburns) → review+
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8945814 [details]
Bug 1433422 - Add basic form control tests for Element Send Keys.
https://reviewboard.mozilla.org/r/215910/#review221958
Attachment #8945814 -
Flags: review?(dburns) → review+
Comment 12•7 years ago
|
||
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e87115ab4b57
Show full pytest failure logs. r=jgraham
https://hg.mozilla.org/integration/autoland/rev/1b0a57e45822
Move caret after focussing element. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/af46ced494e8
Fix interaction.moveCaretToEnd element conditions. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/09304fa512bd
Add basic form control tests for Element Send Keys. r=automatedtester
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e87115ab4b57
https://hg.mozilla.org/mozilla-central/rev/1b0a57e45822
https://hg.mozilla.org/mozilla-central/rev/af46ced494e8
https://hg.mozilla.org/mozilla-central/rev/09304fa512bd
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Assignee | ||
Updated•7 years ago
|
Whiteboard: checkin-needed-beta
Assignee | ||
Updated•7 years ago
|
Whiteboard: checkin-needed-beta → [checkin-needed-beta]
Updated•7 years ago
|
status-firefox58:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Updated•7 years ago
|
Assignee | ||
Comment 14•7 years ago
|
||
This patch doesn’t apply cleanly to beta.
Flags: needinfo?(ato)
Whiteboard: [checkin-needed-beta]
Assignee | ||
Comment 15•7 years ago
|
||
pytest truncates long lists when printing a failed assertion.
This is not great for debugging and arguably it should be the
default to show the full diff when comparing lists.
MozReview-Commit-ID: L8vxIMM9g6m
Assignee | ||
Comment 16•7 years ago
|
||
Focussing the element changes the selection range.
MozReview-Commit-ID: JW68aZupkly
Assignee | ||
Comment 17•7 years ago
|
||
Bug 1432864 introduced a regression where the element conditions
for moving the caret to the end of the textual input were wrong.
Apparently if conditions are hard.
MozReview-Commit-ID: KlRv6sCroXW
Assignee | ||
Comment 18•7 years ago
|
||
We are apparently missing even the most basic tests for Element
Send Keys. This is a moderate contribution.
MozReview-Commit-ID: 9uWtTJ7MFZx
Assignee | ||
Updated•7 years ago
|
Attachment #8945811 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8945812 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8945813 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8945814 -
Attachment is obsolete: true
Assignee | ||
Comment 19•7 years ago
|
||
Sheriffs: Please uplift this to beta. It should now apply cleanly.
Flags: needinfo?(ato)
Whiteboard: [checkin-needed-beta]
Comment 20•7 years ago
|
||
bugherder uplift |
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•