slew Reporter
	Description • 7 years ago

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20100101

Steps to reproduce:

Install reddit enhancement suite
Turn on gfx.webrender.all, restart browser
Visit a reddit page with many gifs, for example https://www.reddit.com/r/gifs/
Attempt to load all gifs inline using the 'Show images' button from reddit enhancement suite.


Actual results:

Most videos show as black or green rectangles. Clicking the links to visit a new page sometimes loads black rectangles.


Expected results:

The videos should display inline and on the image hosts pages.

	Darkspirit
	Comment 1 • 7 years ago

Thanks!

"Show images (60)" will be the last tab in the header.
mozregression --launch 2018-01-27 --pref gfx.webrender.all:true startup.homepage_welcome_url:"https://addons.mozilla.org/en-US/firefox/addon/reddit-enhancement-suite/|https://www.reddit.com/r/gifs/"

I can't reproduce it on Debian Testing (KDE, Radeon RX480).

	slew Reporter
	Comment 2 • 7 years ago

I forgot to add, Windows 7 x64, nVidia GTX 770, drivers are 390.65.

	Milan Sreckovic [:milan] (needinfo for best results)
	Comment 3 • 7 years ago

Slew, do you have access to Windows 10?  Same problem there?

	slew Reporter
	Comment 4 • 7 years ago

Sorry I don't wish to install Windows 10 on this machine. Is it okay if I test it on another machine?

On an older machine with an older build of Windows 10 the bug doesn't happen, Geforce320M and Windows 10 build 1511

	Darkspirit
	Comment 5 • 7 years ago

Could you make a screenshot of the problem and upload it here (Attach File)?
Do you use multiple windows or does this problem already happen if you start Nightly with one window and open Reddit then?

	slew Reporter
	Comment 9 • 7 years ago

I use multiple windows but before I report any bug I make a new profile using the profile manager and follow the exact steps I put on the bug. So I guess this is one window and reddit. An interesting thing I discovered was that the inbuilt screenshot function displays the image just fine (Screen Shot 2018-01-29 at 19.07.14-fullpage.jpg).

On my display you can see on screenshot 1 that most images are green rectangles (sometimes black), in screenshot 2 not all images have that issue.

	Darkspirit
	Comment 10 • 7 years ago
workaround

Just for curiosity: Would it help to set gfx.webrender.all to true and gfx.webrender.force-angle to false?

	slew Reporter
	Comment 11 • 7 years ago

Yes that fixes this problem. However it makes the window decorations (which are already broken in bug 1416288) even more broken.

	Darkspirit
	Comment 12 • 7 years ago

Could you also make a screenshot of that, please?

	slew Reporter
	Comment 13 • 7 years ago

The min/max/close buttons are now black, as well as all the glass themed top being solid white.

	Sotaro Ikeda [:sotaro] Assignee
	Comment 14 • 7 years ago

When I tested the STR in comment 0 locally with 3 win10 PCs, but I could not reproduce the problem.

	Sotaro Ikeda [:sotaro] Assignee
	Comment 15 • 7 years ago

I tested the STR of comment 0 on my win7 PCs and I seemed to reproduce the problem.

When I turn on WebRender with "gfx.webrender.all", I saw the some videos were not rendered correctly. Instead some video were rendered as black or green rectangles.

When I turn on WebRender with "gfx.webrender.enabled", I saw that all videos and almost all images were rendered as black. The difference seemed to come from "gfx.webrender.blob-images". They prevent to use D3D Texture as data storage for images and fallbacked images.

	Sotaro Ikeda [:sotaro] Assignee
	Comment 16 • 7 years ago

From comment 15, it seems that somehow direct d3d texture binding seemed not work with ANGLE. One possible problem is driver's problem. When I disabled WebRender and opened "about:support", there were "NO_CONSTANT_BUFFER_OFFSETTING : Unsupported by driver", when "Direct3d 11 (Advanced Layers)" was used as compositor.

NO_CONSTANT_BUFFER_OFFSETTING check was added to MLGDevice by Bug 1379413. It handles the case that driver does not support constant buffer offsetting.

	Sotaro Ikeda [:sotaro] Assignee
	Comment 17 • 7 years ago

In Bug 1379413, when driver does not support constant buffer offsetting, MLGDeviceD3D11 disables ID3D11DeviceContext1::[V|P]SSetConstantBuffers1 usages.

But ANGLE uses ID3D11DeviceContext1::[V|P]SSetConstantBuffers1 in StateManager11::syncUniformBuffers()
 > https://dxr.mozilla.org/mozilla-central/source/gfx/angle/src/libANGLE/renderer/d3d/d3d11/StateManager11.cpp#2888
 > https://dxr.mozilla.org/mozilla-central/source/gfx/angle/src/libANGLE/renderer/d3d/d3d11/StateManager11.cpp#2941

	Sotaro Ikeda [:sotaro] Assignee
	Comment 18 • 7 years ago

But for now, we could just assume that a driver bug might cause the problem.

	Sotaro Ikeda [:sotaro] Assignee
	Comment 19 • 7 years ago

My case was caused by regression of Bug 1415754. When RenderDXGITextureHostOGL and RenderDXGIYCbCrTextureHostOGL does not support ANGLE_stream_producer_d3d_texture_nv12(NV12 format), they does not render d3d texture. Bug 1415754 addressed the crash, but the way of fixing was not good :(

	Sotaro Ikeda [:sotaro] Assignee
	Comment 20 • 7 years ago

Slew, can you confirm if the problem is addressed with latest m-c?

	slew Reporter
	Comment 21 • 7 years ago

I'm not sure what m-c is but the problem is fixed if I reenable force-angle on the latest nightly, yes.

	Sotaro Ikeda [:sotaro] Assignee
	Comment 22 • 7 years ago

Thanks! Sorry, I used m-c for nightly.

	Sotaro Ikeda [:sotaro] Assignee
	Comment 23 • 7 years ago

m-c is short hand notation of mozilla-central