Comment on attachment 8946834 [details] [diff] [review] release-12-1.patch Review of attachment 8946834 [details] [diff] [review]: ----------------------------------------------------------------- Really weird indentation in the source tree (shared a picture in #releases on slack). Leaving it up to you to push or fix. Localization note labels can be fixed in the next batch (submitted https://github.com/devtools-html/debugger.html/pull/5263) ::: devtools/client/locales/en-US/debugger.properties @@ +24,4 @@ > copySourceUri2=Copy source URI > copySourceUri2.accesskey=u > > # LOCALIZATION NOTE (setDirectoryRoot): This is the text that appears in the Wrong localization note @@ +28,5 @@ > # context menu to set a directory as root directory > setDirectoryRoot.label=Set directory root > setDirectoryRoot.accesskey=r > > +# LOCALIZATION NOTE (removeDirectoryRoot): This is the text that appears in the Wrong localization note @@ +36,1 @@ > # LOCALIZATION NOTE (copyFunction): This is the text that appears in the Wrong localization note

Comment on attachment 8946834 [details] [diff] [review] release-12-1.patch Review of attachment 8946834 [details] [diff] [review]: ----------------------------------------------------------------- Some comments from yesterday that I managed to lose. ::: devtools/client/debugger/new/test/mochitest/examples/sourcemaps-reload/package.json @@ +1,4 @@ > +{ > + "name": "sourcemaps-reload", > + "version": "1.0.0", > + "description": "", "Rebuild assets for sourcemaps-reload test, see README.md in the same folder" @@ +1,5 @@ > +{ > + "name": "sourcemaps-reload", > + "version": "1.0.0", > + "description": "", > + "main": "sorted.js", File does not exist. @@ +7,5 @@ > + "test": "echo \"Error: no test specified\" && exit 1" > + }, > + "keywords": [], > + "author": "", > + "license": "ISC", MPL.

Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/70045e7a2bb3 Update Debugger Frontend v12. r=jdescottes

Landed on inbound. We are aware of the issues related to the Source Tree indentation and UI. They should be fixed in tomorrow's release, v13.0.

This update very slightly regressed: * simple.open by 1.6% * simple.reload by 1.8% (debugger is slightly slower to open and reload against an empty page)