Closed
Bug 1434050
Opened 7 years ago
Closed 7 years ago
Inline report phishing overlay
Categories
(Toolkit :: Safe Browsing, enhancement, P3)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: bdahl, Assigned: bdahl)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-review-board-request
|
Details |
report-phishing-overlay.xul is only used in browser.xul and should be inlined or included with the preprocessor.
|
||
Updated•7 years ago
|
Priority: -- → P3
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → bdahl
| Comment hidden (mozreview-request) |
|
|
||
Updated•7 years ago
|
Attachment #8946944 -
Flags: review?(francois) → review?(jhofmann)
|
|
||
Comment 2•7 years ago
|
||
Redirecting the review to Johann since I'm not comfortable enough in XUL to review this.
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8946944 [details] Bug 1434050 - Inline phishing overlay into the browser. https://reviewboard.mozilla.org/r/216800/#review222672 I believe you also need to update https://searchfox.org/mozilla-central/rev/c56f656febb1aa58c72b218699e24a76425bd284/browser/base/content/moz.build#157
Attachment #8946944 -
Flags: review?(jhofmann) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Pushed by bdahl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/086ddee2bb4d Inline phishing overlay into the browser. r=johannh
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/086ddee2bb4d
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•