Brendan Dahl [:bdahl] Assignee
	Description • 7 years ago

These overlays are also only used once:

chrome://pippki/content/certDump.xul
chrome://pippki/content/OrphanOverlay.xul

	Dana Keeler (she/her) (use needinfo) (:keeler for reviews)
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8946529 [details]
Bug 1434151 - Inline and remove the various certificate viewer overlays.

https://reviewboard.mozilla.org/r/216548/#review222804

Looks good - just some documentation comments.

::: commit-message-c0f08:1
(Diff revision 1)
> +Bug 1434151 - Inline and remove the various certificate viewer overlays. r?keeler

Looks like there is some documentation referencing certDump.xul and viewCertDetails.xul in security/manager/pki/resources/content/certViewer.js - if you could update that, that would be great.

::: commit-message-c0f08:3
(Diff revision 1)
> +Bug 1434151 - Inline and remove the various certificate viewer overlays. r?keeler
> +
> +This is part of the work to remove XUL overlays. All of these overlays are

truncated commit message?

	Pulsebot
	Comment 5 • 7 years ago

Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33e7010243bf
Inline and remove the various certificate viewer overlays. r=keeler

	Narcis Beleuzu [:NarcisB]
	Comment 6 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/33e7010243bf