Closed Bug 1434440 Opened 7 years ago Closed 7 years ago

Don't use raw pointers / manual memory management for ThreadInfo

Categories

(Core :: Gecko Profiler, enhancement)

Product:
Core
Component:
Gecko Profiler
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

ThreadInfo objects are currently owned by the mLiveThreads and mDeadThreads arrays in CorePS, and there's a weak pointer to the current thread's ThreadInfo in the TLS variable sThreadInfo. As threads get removed from mLiveThreads or mDeadThreads, we manually delete these objects. We should at least use UniquePtr for the owning pointers, or maybe even make ThreadInfo refcounted.
Depends on: 1437428
Fixed by bug 1437428.
Assignee: nobody → mstange
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.