Once bug 1430857 lands, we can expand the CertAnnotator to report info to the modules ping in telemetry. (See https://bugzilla.mozilla.org/show_bug.cgi?id=1430857#c3)

(Note: data review for this functionality was done as part of bug 1430857) This patch adds the certSubject field to the modules ping. To control ping size, we just omit the field when it isn't present (instead of setting to null), as it is common for a module to lack a signature.

Comment on attachment 8956949 [details] [diff] [review] Add cert subject to modules ping when available Review of attachment 8956949 [details] [diff] [review]: ----------------------------------------------------------------- Two smallish comments, only. ::: toolkit/components/telemetry/tests/unit/test_TelemetryModules.js @@ +70,5 @@ > + name: "ntdll.dll", > + // This value changes depending on OS version and is irrelevant to this test > + debugName: false, > + // This value changes depending on OS version and is irrelevant to this test > + version: false, Instead of using a boolean type check, could we omit them from the struct and check `if ("version" in lib.version)`. We could render them as commented-out here to show we're doing so deliberately. Then it would line up with how most test libs don't have `certSubject` @@ +204,5 @@ > } else { > Assert.greater(test_lib.debugID.length, 0, "The " + lib.name + " module has a debug ID."); > } > + > + if (lib.certSubject !== undefined) { It would be slightly more precise to check `if ("certSubject" in lib)` to catch cases where it is defined as undefined. (*sigh* JavaScript)

Changes made as suggested.

Comment on attachment 8956959 [details] [diff] [review] Add cert subject to modules ping when available (r2) Review of attachment 8956959 [details] [diff] [review]: ----------------------------------------------------------------- LGTM

https://hg.mozilla.org/integration/mozilla-inbound/rev/22ba4f32a7afe64038a38cd2e1fc16ede661f9ab Bug 1434489: Add optional certSubject field to modules ping; r=chutten, data-review=francois (via bug 1430857)