Closed Bug 1434904 Opened 7 years ago Closed 7 years ago

Remove dependency to testSize.html in test_elementsize.py

Categories

(Remote Protocol :: Marionette, enhancement, P3)

Product:
Remote Protocol
Component:
Marionette
Version:
Version 3
Type:
enhancement

Tracking

(firefox60 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: whimboo, Assigned: iceman, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=py])

User Story

For steps in how to get started please consult our documentation for new users:
https://firefox-source-docs.mozilla.org/testing/marionette/marionette/NewContributors.html

In the case of questions you can find us on IRC in the #ateam channel.

Attachments

(2 files)

Bug 1434904 - Remove dependency to testSize.html in test_elementsize.py
(deleted), text/x-review-board-request
ato
: review+
Details
Bug 1434904 - Delete testSize.html test case
(deleted), text/x-review-board-request
ato
: review+
Details
The following test is using an external HTML testcase, which is simple enough to get integrated as data URL directly into the test. For Marionette unit tests we make use of the `inline` method. Here an example: https://dxr.mozilla.org/mozilla-central/rev/a928be5dacc3b544e29c0612b3f8cda6447df802/testing/marionette/harness/marionette_harness/tests/unit/test_typing.py#14 The same method should be applied to the following test: https://dxr.mozilla.org/mozilla-central/rev/default/testing/marionette/harness/marionette_harness/tests/unit/test_elementsize.py By adding as minimal necessary code from the following HTML testcase: https://dxr.mozilla.org/mozilla-central/rev/default/testing/marionette/harness/marionette_harness/www/testSize.html The HTML testcase should be deleted afterward.
No longer depends on: 1423661
Blocks: 1423638
Hello, I would like to work on this for my first bug. Is that okay?
Please go ahead and attach your patch.
Hello, I'm attached my patch, I didn't hear Sabot's changes about 15 days. Anyway, if Sabot will decide to continue work on the bug, feel free to delete my patch.
Comment on attachment 8951858 [details] Bug 1434904 - Remove dependency to testSize.html in test_elementsize.py https://reviewboard.mozilla.org/r/221144/#review227144
Attachment #8951858 - Flags: review+
Comment on attachment 8951859 [details] Bug 1434904 - Delete testSize.html test case https://reviewboard.mozilla.org/r/221150/#review227146
Attachment #8951859 - Flags: review+
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/022b0205b80e Remove dependency to testSize.html in test_elementsize.py r=ato https://hg.mozilla.org/integration/autoland/rev/e1ac6bfbb020 Delete testSize.html test case r=ato
https://hg.mozilla.org/mozilla-central/rev/022b0205b80e https://hg.mozilla.org/mozilla-central/rev/e1ac6bfbb020
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Comment on attachment 8951859 [details] Bug 1434904 - Delete testSize.html test case https://reviewboard.mozilla.org/r/221150/#review227252
Attachment #8951859 - Flags: review?(hskupin)
Attachment #8951858 - Flags: review?(hskupin)
Assignee: nobody → mykhaylo.yusko
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: