Closed
Bug 1434913
Opened 7 years ago
Closed 6 years ago
make FetchEvent.clientId non-nullable
Categories
(Core :: DOM: Service Workers, enhancement, P2)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: bkelly, Assigned: perry)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The spec currently defines FetchEvent.clientId as non-nullable. We still have the old nullable version. I had planned to wait to implement this in bug 1264177, but some WPT tests have changed to expect this. Some discussion here:
https://github.com/w3c/ServiceWorker/issues/1266
Also, chrome has implemented and is planning to ship in chrome 66:
https://www.chromestatus.com/feature/5942197618737152
|
||
Updated•7 years ago
|
Priority: -- → P2
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → pjiang
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•6 years ago
|
||
Make FetchEvent.clientId non-nullable
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8997940 [details]
Make FetchEvent.clientId non-nullable
Blake Kaplan (:mrbkap) has approved the revision.
https://phabricator.services.mozilla.com/D2789
Attachment #8997940 -
Flags: review+
Pushed by bugmail@asutherland.org:
https://hg.mozilla.org/integration/autoland/rev/73847b793895
Make FetchEvent.clientId non-nullable r=mrbkap
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•