Closed
Bug 1434968
Opened 7 years ago
Closed 7 years ago
mSavedStreamedSamples and mSavedStreamedMarkers are kept alive even after the profiler is stopped
Categories
(Core :: Gecko Profiler, defect)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
mSavedStreamedSamples and mSavedStreamedMarkers are really something that should only exist during a single run of the profiler. But they're stored on ThreadInfo, which exists throughout the thread's lifetime, even if the profiler is not running. And there is no code that manually clears these strings when the profiler is stopped, as far as I can tell.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8948843 [details]
Bug 1434968 - Clear mUniqueStacks, mSavedStreamedSamples and mSavedStreamedMarkers when the profiler is stopped.
https://reviewboard.mozilla.org/r/218220/#review224042
Attachment #8948843 -
Flags: review?(n.nethercote) → review+
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/ad00751ceb1b
Clear mUniqueStacks, mSavedStreamedSamples and mSavedStreamedMarkers when the profiler is stopped. r=njn
Comment 4•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•