Closed
Bug 1434988
Opened 7 years ago
Closed 7 years ago
Audio loopback mochitest may use private devices on linux (and it can be loud!)
Categories
(Core :: WebRTC: Audio/Video, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: pehrsons, Assigned: pehrsons)
References
Details
Attachments
(1 file)
When running `./mach test` with --use-test-media-devices everything is jolly.
When running without --use-test-media-devices, MediaManager the null-sink does not get set and MediaManager does not pick up the null monitor for recordings (whether it exists or not).
|
Assignee | |
Comment 1•7 years ago
|
||
We could make the test a noop when there are no test-media-devices set.
|
|
Assignee | |
Updated•7 years ago
|
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8947547 [details]
Bug 1434988 - Make audio loopback mochitest return early without loopback device set up.
https://reviewboard.mozilla.org/r/217248/#review223202
Nice catch.
Attachment #8947547 -
Flags: review?(achronop) → review+
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6b68b2658dc4
Make audio loopback mochitest return early without loopback device set up. r=achronop
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•