Closed
Bug 1435045
Opened 7 years ago
Closed 6 years ago
Huge blob image jank on https://blog.openai.com/requests-for-research-2/
Categories
(Core :: Graphics: WebRender, enhancement, P2)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox58 | --- | unaffected |
firefox59 | --- | unaffected |
firefox60 | --- | disabled |
firefox63 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: mstange)
References
(Blocks 1 open bug, )
Details
(Keywords: perf)
Attachments
(1 file)
https://perfht.ml/2ntifR9
We're doing a bunch of blur. I'm not sure why it's so slow.
Things that can be done to fix it:
- Figure out why it's so slow (it shouldn't be as bad as it is)
- The blur should be handled by WebRender because it's outside of the svg
- Reduce the tile size of blob image so that we parallel paint it.
Updated•7 years ago
|
Blocks: webrender-site-issues
status-firefox58:
--- → unaffected
status-firefox59:
--- → unaffected
status-firefox60:
--- → disabled
status-firefox-esr52:
--- → unaffected
Keywords: perf
Updated•7 years ago
|
Blocks: stage-wr-trains
Priority: -- → P2
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #0)
> https://perfht.ml/2ntifR9
>
> We're doing a bunch of blur. I'm not sure why it's so slow.
>
> Things that can be done to fix it:
> - Figure out why it's so slow (it shouldn't be as bad as it is)
I think it's just a gigantic blur radius and we don't do anything smart (like downscale-before-blur) to address that.
> - The blur should be handled by WebRender because it's outside of the svg
I've attached a patch that fixes this part.
> - Reduce the tile size of blob image so that we parallel paint it.
We're still not using tiles for blob images effectively, so this still needs to be fixed.
Reporter | ||
Comment 3•6 years ago
|
||
Comment on attachment 9003292 [details]
Bug 1435045 - Don't make CSS filters on the <svg> element use fallback. r=jrmuizel
Jeff Muizelaar [:jrmuizel] has approved the revision.
Attachment #9003292 -
Flags: review+
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/d77ca862636d
Don't make CSS filters on the <svg> element use fallback. r=jrmuizel
Comment 5•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•6 years ago
|
Assignee: nobody → mstange
You need to log in
before you can comment on or make changes to this bug.
Description
•