Closed
Bug 1435079
Opened 7 years ago
Closed 7 years ago
Consider running fewer tests for non-gradle builds ("Android API16+ Gradle opt")
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla60
People
(Reporter: gbrown, Assigned: gbrown)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
I haven't seen any significant differences between test results for android gradle vs non-gradle builds. Do we need to keep running the non-gradle tests? If so, could we reduce the set of tests?
If they are valuable, they can certainly continue to run. I'm just challenging the status quo here in hopes of increasing efficiency.
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(snorp)
Flags: needinfo?(nalexander)
Comment 1•7 years ago
|
||
(In reply to Geoff Brown [:gbrown] from comment #0)
> I haven't seen any significant differences between test results for android
> gradle vs non-gradle builds. Do we need to keep running the non-gradle
> tests? If so, could we reduce the set of tests?
>
> If they are valuable, they can certainly continue to run. I'm just
> challenging the status quo here in hopes of increasing efficiency.
I'd like to keep something for non-Gradle to smoketest, but just Robocop would achieve that. None of the M, R, X are adding much value.
I've been thinking of https://bugzilla.mozilla.org/show_bug.cgi?id=1414415 again... I should do that.
But for now, just a smoketest, please!
Flags: needinfo?(nalexander)
Assignee | ||
Comment 2•7 years ago
|
||
Sure, let's go with just Robocop for now then. Will put together a patch tomorrow.
Flags: needinfo?(snorp)
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8947906 -
Flags: review?(jmaher)
Updated•7 years ago
|
Attachment #8947906 -
Flags: review?(jmaher) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1bda868b03a3
Stop running most Android non-gradle tests; r=jmaher
Comment 6•7 years ago
|
||
Oh nevermind, the tests we label "Gradle" are really non-Gradle ones. That's not at all misleading.
Flags: needinfo?(gbrown)
Assignee | ||
Comment 7•7 years ago
|
||
Right, it's the tier 2 tests that are being reduced here.
Comment 8•7 years ago
|
||
bugherder uplift |
Assignee | ||
Updated•7 years ago
|
Comment 9•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Updated•7 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•