Closed
Bug 1435132
Opened 7 years ago
Closed 7 years ago
Remove some COM bits from nsIStyleSheetLinkingElement
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(3 files)
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
MozReview-Commit-ID: EibysYsW1rv
Attachment #8947690 -
Flags: review?(continuation)
Assignee | ||
Comment 2•7 years ago
|
||
MozReview-Commit-ID: 2maFIxR2HkS
Attachment #8947691 -
Flags: review?(continuation)
Assignee | ||
Comment 3•7 years ago
|
||
MozReview-Commit-ID: K7mnYXOJOK6
Attachment #8947692 -
Flags: review?(continuation)
Updated•7 years ago
|
Attachment #8947690 -
Flags: review?(continuation) → review+
Comment 4•7 years ago
|
||
Comment on attachment 8947691 [details] [diff] [review]
part 2. Make nsIStyleSheetLinkingElement::GetCharset infallible
Review of attachment 8947691 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/base/nsIStyleSheetLinkingElement.h
@@ +75,5 @@
> virtual void SetEnableUpdates(bool aEnableUpdates) = 0;
>
> /**
> + * Gets the charset that the element claims the style sheet is in.
> + * Can return empty string to indicate that we have no charser
nit: charser -> charset
Attachment #8947691 -
Flags: review?(continuation) → review+
Updated•7 years ago
|
Attachment #8947692 -
Flags: review?(continuation) → review+
Assignee | ||
Comment 5•7 years ago
|
||
> nit: charser -> charset
Fixed.
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2d16fa076a7
part 1. Remove NS_IMETHOD noise from never-failing nsIStyleSheetLinkingElement methods. r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3be06248ef5
part 2. Make nsIStyleSheetLinkingElement::GetCharset infallible. r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/965c5adb6982
part 3. Remove the last NS_IMETHOD bit from nsIStyleSheetLinkingElement. r=mccr8
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d2d16fa076a7
https://hg.mozilla.org/mozilla-central/rev/b3be06248ef5
https://hg.mozilla.org/mozilla-central/rev/965c5adb6982
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•