Closed
Bug 1435181
Opened 7 years ago
Closed 7 years ago
Migration should warn about unknown FTL entities in add_transforms()
Categories
(Localization Infrastructure and Tools :: Fluent Migration, enhancement)
Localization Infrastructure and Tools
Fluent Migration
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: flod, Assigned: stas)
Details
Attachments
(1 file)
|
(deleted),
text/x-github-pull-request
|
Details |
I was trying to test locally bug 1424683, but the migration came out empty. It turns out, the FTL.Identifier was mispelled.
The migration code should warn when a migration is not found in the FTL file.
|
Assignee | |
Updated•7 years ago
|
Blocks: fluent.migrate
|
|
Assignee | |
Comment 1•7 years ago
|
||
That could create a log of noise for incomplete locales. Are you OK with that?
Flags: needinfo?(francesco.lodolo)
|
Reporter | |
Comment 2•7 years ago
|
||
I'm not sure we're talking about the same issue.
The migration had
id=FTL.Identifier('brand-short-name'),
while the FTL had -brand-short-name (message vs term), resulting in an empty migration.
Is it possible to warn in such cases, i.e. the term is not available in the source en-US file?
Flags: needinfo?(francesco.lodolo)
|
|
Assignee | |
Comment 3•7 years ago
|
||
Ah, I see now! Thanks for the clarification. It should be doable, I'll see what I can do.
|
|
Assignee | |
Comment 4•7 years ago
|
||
Assignee: nobody → stas
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 5•7 years ago
|
||
Fixed in https://github.com/projectfluent/python-fluent/commit/cb318cb39ca8c9a2ddf559a84ed2b620a616028e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•7 years ago
|
No longer blocks: fluent.migrate
Component: Python Library → Fluent Migration
Product: L20n → Localization Infrastructure and Tools
You need to log in
before you can comment on or make changes to this bug.
Description
•