Sylvestre Ledru [:Sylvestre] Assignee
	Description • 7 years ago

In file included from /root/firefox-gcc-last/dom/media/FileBlockCache.h:16,
                  from /root/firefox-gcc-last/dom/media/FileBlockCache.cpp:7,
                  from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dom/media/Unified_cpp_dom_media3.cpp:38:
 /root/firefox-gcc-last/dom/media/MediaBlockCacheBase.h: At global scope:
 /root/firefox-gcc-last/dom/media/MediaBlockCacheBase.h:43:68: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
        static_cast<decltype(MediaCacheStream::BLOCK_SIZE)>(INT32_MAX),
                                                                     ^
Thanks Benjamin for the help!

	Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8947826 [details]
Bug 1435262 - Remove the const type qualifiers to silent a gcc 8 warning

https://reviewboard.mozilla.org/r/217520/#review223450

Thank you for the fix.

LGTM as-is, but here's an optional nit:

::: dom/media/MediaBlockCacheBase.h:43
(Diff revision 1)
>  public:
>    NS_INLINE_DECL_THREADSAFE_REFCOUNTING(MediaBlockCacheBase)
>  
>    static_assert(
>      MediaCacheStream::BLOCK_SIZE <
> -      static_cast<decltype(MediaCacheStream::BLOCK_SIZE)>(INT32_MAX),
> +      static_cast<std::remove_cv<decltype(MediaCacheStream::BLOCK_SIZE)>::type>(INT32_MAX),

remove_const would suffice here.

	Pulsebot
	Comment 4 • 7 years ago

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6873d1a8a2ad
Remove the const type qualifiers to silent a gcc 8 warning r=gerald

	Mozilla Autoland
	Comment 5 • 7 years ago

We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.

	Mozilla Autoland
	Comment 7 • 7 years ago

We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.

	Mozilla Autoland
	Comment 9 • 7 years ago

We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.

	Sylvestre Ledru [:Sylvestre] Assignee
	Comment 10 • 7 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb87c9467a3598f9cf9fddfcb31fdcc42fc79241
Bug 1435262 - Remove the const type qualifiers to silent a gcc 8 warning r=gerald

	Cosmin Sabou [:CosminS]
	Comment 11 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/6873d1a8a2ad

	Natalia Csoregi [:nataliaCs]
	Comment 12 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/eb87c9467a35

	Chris Pearce [:cpearce (Not reading bugmail)]
	Comment 13 • 7 years ago

Comment on attachment 8947826 [details]
Bug 1435262 - Remove the const type qualifiers to silent a gcc 8 warning

Thanks for the patch; sorry for the delay on the review, looks like you got it landed anyway.