Closed Bug 1435512 Opened 7 years ago Closed 5 years ago

Crash in xpc::XrayTraits::getHolder

Categories

(Core :: XPConnect, defect)

58 Branch
Unspecified
Windows
defect
Not set
critical

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: philipp, Unassigned)

References

Details

(Keywords: crash, regression)

Crash Data

This bug was filed from the Socorro interface and is report bp-57af50df-1edb-43b9-8ed9-0a79f0180202. ============================================================= Top 10 frames of crashing thread: 0 xul.dll xpc::XrayTraits::getHolder js/xpconnect/wrappers/XrayWrapper.cpp:1393 1 xul.dll xpc::XrayTraits::ensureHolder js/xpconnect/wrappers/XrayWrapper.cpp:1400 2 xul.dll xpc::XrayTraits::attachExpandoObject js/xpconnect/wrappers/XrayWrapper.cpp:1274 3 xul.dll xpc::XrayTraits::cloneExpandoChain js/xpconnect/wrappers/XrayWrapper.cpp:1333 4 xul.dll xpc::TransplantObjectRetainingXrayExpandos js/xpconnect/wrappers/WrapperFactory.cpp:697 5 xul.dll mozilla::dom::ReparentWrapper dom/bindings/BindingUtils.cpp:2273 6 xul.dll nsNodeUtils::CloneAndAdopt dom/base/nsNodeUtils.cpp:605 7 xul.dll nsIDocument::AdoptNode dom/base/nsDocument.cpp:8163 8 xul.dll nsINode::ReplaceOrInsertBefore dom/base/nsINode.cpp:2448 9 xul.dll mozilla::dom::NodeBinding::appendChild dom/bindings/NodeBinding.cpp:885 ============================================================= these content crashes on windows are highly correlated to the presence of the Dashlane extension.
Bobby, I'm trying to triage this, but really no sure of what to make of it. I see xpconnect, so I thought you would have something to say.
Flags: needinfo?(bobbyholley)
I'm guessing this is a regression from bug 1404107. Presumably there's a pattern of Xray access that happens in Dashlane but not in our test suite.
Flags: needinfo?(bobbyholley) → needinfo?(jorendorff)
Blocks: 1404107
Keywords: regression

Closing as WORKSFORME. In the last six months, there have been zero [@ xpc::XrayTraits::getHolder ] crash reports and only 14 [@ xpc::XrayTraits::ensureHolder ] crash reports (7 from 52.9.0esr and 7 from 60.9.0esr, neither of which is still supported).

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(jorendorff)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.