Closed
Bug 1435764
Opened 7 years ago
Closed 7 years ago
Allow Cu.importGlobalProperties for NodeFilter
Categories
(Core :: XPConnect, enhancement, P2)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(4 files, 1 obsolete file)
(deleted),
patch
|
kmag
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
kmag
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
kmag
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
kmag
:
review+
|
Details | Diff | Splinter Review |
We can use this in various places where we just ended up hardcoding stuff in bug 1434819.
Assignee | ||
Comment 1•7 years ago
|
||
The members that correspond to interface names should match the interface names.
MozReview-Commit-ID: FB8vpX2IIt9
Attachment #8948455 -
Flags: review?(kmaglione+bmo)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•7 years ago
|
||
Alphabetical order, of course. First interfaces, then ad-hoc things.
MozReview-Commit-ID: Dz9XGMNoRo
Attachment #8948456 -
Flags: review?(kmaglione+bmo)
Assignee | ||
Comment 3•7 years ago
|
||
MozReview-Commit-ID: Gv77ey3bHcs
Attachment #8948457 -
Flags: review?(kmaglione+bmo)
Assignee | ||
Comment 4•7 years ago
|
||
MozReview-Commit-ID: HuwuVXWcWQE
Attachment #8948458 -
Flags: review?(kmaglione+bmo)
Assignee | ||
Comment 5•7 years ago
|
||
MozReview-Commit-ID: HuwuVXWcWQE
Attachment #8948487 -
Flags: review?(kmaglione+bmo)
Assignee | ||
Updated•7 years ago
|
Attachment #8948458 -
Attachment is obsolete: true
Attachment #8948458 -
Flags: review?(kmaglione+bmo)
Updated•7 years ago
|
Attachment #8948455 -
Flags: review?(kmaglione+bmo) → review+
Updated•7 years ago
|
Attachment #8948456 -
Flags: review?(kmaglione+bmo) → review+
Updated•7 years ago
|
Attachment #8948457 -
Flags: review?(kmaglione+bmo) → review+
Updated•7 years ago
|
Attachment #8948487 -
Flags: review?(kmaglione+bmo) → review+
Updated•7 years ago
|
Priority: -- → P2
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/637dffdef3fb
part 1. Fix up the naming of some xpc::GlobalProperties members. r=kmag
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2694e3d4248
part 2. Order the members of xpc::GlobalProperties in a sensible way. r=kmag
https://hg.mozilla.org/integration/mozilla-inbound/rev/6612182e2011
part 3. Add NodeFilter to xpc::GlobalProperties. r=kmag
https://hg.mozilla.org/integration/mozilla-inbound/rev/b320d109ead2
part 4. Use NodeFilter in various system-JS places instead of hardcoding constant values. r=kmag
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/637dffdef3fb
https://hg.mozilla.org/mozilla-central/rev/e2694e3d4248
https://hg.mozilla.org/mozilla-central/rev/6612182e2011
https://hg.mozilla.org/mozilla-central/rev/b320d109ead2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•