Closed Bug 143579 Opened 23 years ago Closed 23 years ago

Character coding menu of the linked page does not inherite from the one user forced page

Categories

(Core :: Internationalization, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: teruko, Assigned: shanjian)

References

()

Details

(Keywords: intl, regression)

Attachments

(1 file)

Character coding menu of the linked page does not inherite from the one user 
forced to changed the character coding in the page.

Steps of reproduce
1. Make sure the Auto-Detect is not on
2. Go to above url
Since the default character coding is set to ISO-8859-1, Japanese characters are 
displayed as garbage.
3. Select menu View|Character coding->More->East Asian->Japanese (Euc-JP)
Japanese characters are displayed correctly.
4. Click the link "world succer" in Japanese
It goes to http://shopping.yahoo.co.jp/world_soccer/.  This page does not have 
meta charset.

Expected result
Japanese characters are displayed correctly.

Actual result
Japanese characters are displayed as garbage.

Tested 5-10-2002-1.00 build.  This behavior is different from NS 6.22.
Keywords: intl
QA Contact: ruixu → teruko
adding regression keyword.
shanjian: any clues on what may have caused this?
Status: NEW → ASSIGNED
Keywords: regression
I have no idea. I remember that charset inheritance is done in navigator.js,
around this part of code:
356 var turboMode = false;
357 // set default character set if provided
358 if ("arguments" in window && window.arguments.length > 1 &&
window.arguments[1]) {
359 if (window.arguments[1].indexOf("charset=") != -1) {
360 var arrayArgComponents = window.arguments[1].split("=");
361 if (arrayArgComponents) {
362 //we should "inherit" the charset menu setting in a new window
363 getMarkupDocumentViewer().defaultCharacterSet = arrayArgComponents[1];
364 }
365 } else if (window.arguments[1].indexOf("turbo=yes") != -1) {
366 turboMode = true;
367 }
368 }

Nominating this to nsbeta1.
Keywords: nsbeta1
Is it really a regression. I remember the force charset behavior only impact
that particular loading. 
Assignee: yokoyama → shanjian
Status: ASSIGNED → NEW
Yes.  This is regression. 6.2 remembered the forced charset.
nsbeta1+
Keywords: nsbeta1nsbeta1+
Attached patch patch (deleted) β€” β€” Splinter Review
This is a regression caused by change in nsHTMLDocument.cpp. Default charset's
priority is higher than weakDocTypeDefault. After I correct the charset
resolution order, it works fine as before. 

roy/ftang, could you review? 
Status: NEW → ASSIGNED
fix checked into trunk. 
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
I verified as fixed in 6-12 Win32, Linux, and Mac trunk build.
Now the fix is available in branch as well.
(patch included in bug 102407)
Keywords: fixed1.0.1
Verified as fixed in 6-14-1.0 Mac, Win32, and Linux build.
Status: RESOLVED → VERIFIED
Keywords: verified1.0.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: