Closed Bug 1436228 Opened 7 years ago Closed 7 years ago

Green up our JS dependencies for Firefox 61

Categories

(Firefox :: New Tab Page, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 61
Iteration:
61.4 - May 7
Tracking Status
firefox60 --- wontfix
firefox61 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

(Blocks 3 open bugs)

Details

Attachments

(1 file)

Let's try to keep our dependencies up to date each cycle. Steps: 1) green up dependencies that are already passing tests - next-update --test './node_modules/.bin/npm-run-all test buildmc' --type dev - for non-dev dependencies, probably include --test 'npm run mochitest' - maybe --without istanbul-instrumenter-loader,karma-sinon,loader-utils (as they failed previously) 2) fix up dependencies that require changes as separate commits - non-dev dependencies probably require vendor/ file changes 3) create PR with greening up commits - good to link to major version changes release tags -- e.g., https://github.com/mochajs/mocha/releases/tag/v5.0.0 4) file new bug for next cycle
Extra care in not regressing https://github.com/mozilla/activity-stream/pull/4020 if updating karma
Depends on: 1441278
Iteration: 61.1 - Mar 26 → ---
Iteration: --- → 61.2 - Apr 9
Priority: P3 → P2
Severity: normal → enhancement
Iteration: 61.2 - Apr 9 → 61.4 - May 7
Might be worth trying out https://renovateapp.com/ for this. At first glance, it appears to have a bunch of the configurability that we always wished greenkeeper had.
I've got a couple of PRs from it in my fork of activity stream: https://github.com/dmose/activity-stream/pulls
Assignee: nobody → edilee
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/8ed3d178495433768eb4a7bbc90d4f9dd5ae1bc6 Merge pull request #4135 from Mardak/b1436228-green Fix Bug 1436228 - Green up our JS dependencies for Firefox 61
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: 1459296
Blocks: 1459444
Blocks: 1459445
Blocks: 1459446
Blocks: 1459447
Blocks: 1459449
Blocks: 1459450
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: