Closed Bug 1436248 Opened 7 years ago Closed 7 years ago

browser_shortcutkey_modifier_conflicts_with_content_accesskey_modifier.js is going to permafail when Gecko 60 merges to Beta on 2018-03-01

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

Product:
Core
Component:
DOM: UI Events & Focus Handling
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox58 --- unaffected
firefox59 --- fixed
firefox60 + verified

People

(Reporter: RyanVM, Assigned: masayuki)

References

Details

Attachments

(1 file)

Bug 1436248 - Don't use selectionchange event in browser-chrome test since it's not standardized yet whether it should be fired on <input> and <textarea> +6102
(deleted), text/x-review-board-request
enndeakin
: review+
lizzard
: approval-mozilla-beta+
Details
Depending on a feature that's behind a NIGHTLY_BUILD pref? https://treeherder.mozilla.org/logviewer.html#?job_id=160713484&repo=try The patch below should suffice for reproducing the failure locally: https://hg.mozilla.org/try/rev/18bae3eb5e94d4e17c97ebed1f23c4bbc352e923
Flags: needinfo?(masayuki)
Oh, you're right. "selectionchange" event in <input> and <textarea> is enabled only in Nightly build: https://searchfox.org/mozilla-central/rev/84cea84b12145d752e50ddca6be5462c38510e35/modules/libpref/init/all.js#150-155
Flags: needinfo?(masayuki)
Comment on attachment 8948903 [details] Bug 1436248 - Don't use selectionchange event in browser-chrome test since it's not standardized yet whether it should be fired on <input> and <textarea> +6102 https://reviewboard.mozilla.org/r/218300/#review224174
Attachment #8948903 - Flags: review?(enndeakin) → review+
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/3304400da8cb Don't use selectionchange event in browser-chrome test since it's not standardized yet whether it should be fired on <input> and <textarea> r=enndeakin+6102+6102
https://hg.mozilla.org/mozilla-central/rev/3304400da8cb
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Thanks for the quick fix!
Status: RESOLVED → VERIFIED
status-firefox60: fixed → verified
Comment on attachment 8948903 [details] Bug 1436248 - Don't use selectionchange event in browser-chrome test since it's not standardized yet whether it should be fired on <input> and <textarea> +6102 Approval Request Comment [Feature/Bug causing the regression]: Fixing new test's permanent orange of bug 1435530. If we uplift patches for bug 1435530, we need to uplift this too. Otherwise, not necessary.
Attachment #8948903 - Flags: approval-mozilla-beta?
OK, let's take this for beta 59 so we have the option to uplift.
status-firefox59: unaffected → affected
Comment on attachment 8948903 [details] Bug 1436248 - Don't use selectionchange event in browser-chrome test since it's not standardized yet whether it should be fired on <input> and <textarea> +6102 Changes to test so we can fix an e10s issue. Should land in time for beta 10.
Attachment #8948903 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: