Closed
Bug 1436272
Opened 7 years ago
Closed 7 years ago
Move noscript methods in nsIEditor to EditorBase
Categories
(Core :: DOM: Editor, enhancement, P3)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We can use EditorBase/TextEditor/HTMLEditor directly instead of nsIEditor, so we can move noscript methods in nsIEditor to each class.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8948898 [details]
Bug 1436272 - Move noscript methods in nsIEditor to EditorBase.
https://reviewboard.mozilla.org/r/218296/#review224088
Attachment #8948898 -
Flags: review?(masayuki) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/86581d5ccbbb
Move noscript methods in nsIEditor to EditorBase. r=masayuki
|
||
Comment 4•7 years ago
|
||
Backed out changeset 86581d5ccbbb (bug 1436272) for failing /builds/worker/workspace/build/src/editor/libeditor/EditorBase.cpp a=backout on a CLOSED TREE
push that caiused the failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=86581d5ccbbbd370bcb751abf95d9cec6d16458f
latest log for the failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=814985e63c0e0fbea2996af50c2a0e8add8005b1&group_state=expanded&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=161011871&filter-searchStr=windows-mingw32-32%20debug%20build-win32-mingw32%2Fdebug%20(B)
backout: https://hg.mozilla.org/integration/autoland/rev/579f806b99f83b72d3714b8e9670207bd5812d9a
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/725c38dc3991
Move noscript methods in nsIEditor to EditorBase. r=masayuki
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
|
||
Updated•5 years ago
|
Blocks: redesign-editor-scriptable-API
You need to log in
before you can comment on or make changes to this bug.
Description
•