After landing of bug 1427350 we need some fixes.

This patch fixes the no more opening autocomplete list when entering something in the gloda search box. But I get still this error: val.identities is null glautocomp.js:223 Aceman, could you check what is needed to fix this error? This is what they changed: https://hg.mozilla.org/mozilla-central/rev/0969471cf1492adc395cb8fcbc649068d0479c3b

Hmm, apart from white-space changes, this is the only change - if (this._currentIndex >= this._matchCount) + if (this._currentIndex >= this.matchCount) unless I'm missing something. How is this motivated, I see '_matchCount' used in the M-C patch.

It was renamed in the second m-c patch https://hg.mozilla.org/mozilla-central/rev/d5c0c1275597 ans I followed.

Comment on attachment 8948928 [details] [diff] [review] gloda.patch Review of attachment 8948928 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to Richard Marti (:Paenglab) from comment #1) > Created attachment 8948928 [details] [diff] [review] > gloda.patch > > This patch fixes the no more opening autocomplete list when entering > something in the gloda search box. I still get proposals in the gloda search box even without the patch. But there is: TypeError: row is null 1 glodacomplete.xml:51:17 _appendCurrentResult chrome://gloda/content/glodacomplete.xml:51:17 _appendCurrentResult/< chrome://gloda/content/glodacomplete.xml:66:28 Probably becasue of the failing _matchCount above that code. After the patch I see no problems. > But I get still this error: > val.identities is null glautocomp.js:223 I do not get this.

Comment on attachment 8948928 [details] [diff] [review] gloda.patch (In reply to :aceman from comment #4) > I still get proposals in the gloda search box even without the patch. > But there is: > TypeError: row is null 1 glodacomplete.xml:51:17 > _appendCurrentResult chrome://gloda/content/glodacomplete.xml:51:17 > _appendCurrentResult/< chrome://gloda/content/glodacomplete.xml:66:28 > Probably becasue of the failing _matchCount above that code. > > After the patch I see no problems. Yeah, strange. Today Daily shows the proposals too. Only my self built build not. Could we get this landed soon?

Comment on attachment 8948928 [details] [diff] [review] gloda.patch (In reply to Richard Marti (:Paenglab) from comment #5) > Could we get this landed soon? OK. I can confirm that the patch fixes the TypeError: row is null. But there are heaps of other errors, which appear to be pre-existing, they already happen in my slightly older version 60.0a1 (2018-02-02) (64-bit), so I'll file a new bug for those.

Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/f842916b9211 Port bug 1427350 (part 2) to TB: rename _matchCount to matchCount. r=jorgk

I filed bug 1436590 to chase these errors: pv is not defined glodaFacetVis.js:62 TypeError: this.hotBars is undefined glodaFacetVis.js:336:5 TypeError: this.hotBars is undefined glodaFacetVis.js:336:5 ReferenceError: pv is not defined glodaFacetVis.js:62:9 TypeError: this.emptyBins is undefined glodaFacetVis.js:326:9 I've never seen val.identities is null glautocomp.js:223 from comment #1.