Closed
Bug 1436299
Opened 7 years ago
Closed 7 years ago
Changing the USB port of the camera while you are in call conducts to crash
Categories
(Core :: WebRTC: Audio/Video, defect, P2)
Tracking
()
RESOLVED
DUPLICATE
of bug 1436959
People
(Reporter: Ovidiu, Assigned: pehrsons)
References
Details
Crash Data
Attachments
(1 file)
(deleted),
text/plain
|
Details |
Affected versions]:
Tested on Nightly 60.0a1(2018-02-06)
[Affected platforms]:
Tested on Mac OS X 10.12,
[Steps to reproduce]:
Prerequisites:
1. Make sure you have connected 1 camera that uses the USB port.
STR:
1. Open Firefox and go to https://appear.in and start a video call by selecting the camera that you plugged in.
2. Unplug your camera.
3. Plugin the camera but in a different USB port and try to reconnect to the previous call.
[Expected result]:
The camera starts to capture.
[Actual result]:
In the drop-down from where you select what camera to share you have the camera name plus #2. Here is a print screen of this issue: https://imgur.com/a/m8qpV
If I select that camera the browser crashes.
After the first crash, I can connect to the site but the camera name is the same.
NOTE: I tested on Ubuntu and I can't reproduce this issue there, I will try with Windows and I will update this bug if something doesn't work.
The crash signatures are related to bug 1435670.
Reporter | ||
Comment 1•7 years ago
|
||
On Ubuntu, it has different behaviors depending on which site are you.
Appear.in - if you go into settings after you connect the camera, you don't see any camera displayed in the dropdown, only 2 empty boxes.
Jitsi - You can select the camera from the drop-down in the Settings but you are prompted with this message: "Unable to access camera" and the camera doesn't capture anything.
Reporter | ||
Comment 2•7 years ago
|
||
This is reproducible also on Windows7 and 10 but without any crashes, the camera capture freezes. The behavior is similar to the one from Ubuntu.
Comment 3•7 years ago
|
||
Can you get cubeb logs (cubeb:4) from the freeze on Windows case?
Flags: needinfo?(ovidiu.boca)
Reporter | ||
Comment 4•7 years ago
|
||
Hello Alex, please tell me how to do that.
Flags: needinfo?(ovidiu.boca)
Comment 5•7 years ago
|
||
Sure that's a link about it. Go on Windows sections. Replace the MOZ_LOG env with cubeb:4
https://developer.mozilla.org/en-US/docs/Mozilla/Debugging/HTTP_logging
Reporter | ||
Comment 6•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → apehrson
Rank: 8
Priority: -- → P1
Comment 7•7 years ago
|
||
This stack is also the same signature as in Bug 1435670. Not sure if it is a dupe?
Comment 8•7 years ago
|
||
Thanks for the logs, on Windows you hit Bug 1426333. When it is fixed we could probably recheck.
Assignee | ||
Comment 9•7 years ago
|
||
Likely a dupe to 1435670 but since this is where we have an STR I'll use this to investigate.
Status: NEW → ASSIGNED
Assignee | ||
Comment 10•7 years ago
|
||
This crash happens when a camera doesn't report any capabilities at all.
The child ignores this fact (rightfully so for screensharing as it looks from comments) and tries to start it anyway. The parent however, has a hard assumption about there being a capability.
Bug 1419374 fixed a real issue here in 59 and put in a MOZ_DIAGNOSTIC_ASSERT instead. I think this assert should be removed, but note that there's no risk here in release. Reducing priority.
I'm also hitting a crash in the child after this. I imagine that is a regression from bug 1299515 for now but will file bugs accordingly.
Assignee | ||
Comment 11•7 years ago
|
||
I'm duping this and following up in bug 1435670.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Comment 12•7 years ago
|
||
Pondering a bit about this I think it just happens to share symptoms with bug 1435670 but the flaw must be more fundamental. Instead I think this could be related to bug 1436959 -- the unplugged camera doesn't go away so after replugging we're using some stale state from its previous incarnation.
I also got confirmation from Ovidiu on slack that this only happens on Mac, which points to bug 1436959.
With that in mind I'm lowering priority.
Status: RESOLVED → REOPENED
Rank: 8 → 16
Depends on: 1436959
Priority: P1 → P2
Resolution: DUPLICATE → ---
Assignee | ||
Updated•7 years ago
|
status-firefox58:
--- → ?
status-firefox59:
--- → ?
status-firefox-esr52:
--- → ?
OS: Unspecified → Mac OS X
Hardware: Unspecified → All
Assignee | ||
Comment 13•7 years ago
|
||
Ovidiu, with bug 1436959 now fixed, could you retest this on latest Nightly to see if this was fixed in the process?
Flags: needinfo?(ovidiu.boca)
Reporter | ||
Comment 14•7 years ago
|
||
Hi Andreas,
I tested this issue on Windows 10 x64, with FF Nightly 60.0a1(2018-03-05) using the Logitec HD-pro-webcam-c920 and the results are the same as are described in comment 1.
Flags: needinfo?(ovidiu.boca)
Assignee | ||
Comment 15•7 years ago
|
||
Comment 1 is not necessarily a bug, unless you can show that it's a regression by us.
You are after all unplugging the camera in use. You also don't say what microphone device you're using. If that device is in fact the camera you unplug, and you haven't given the page you're testing on persistent permissions, you don't have any live capture going anymore. This is a state that applications don't handle particularly well and, for one, trying to enumerate devices will not give you real labels - which could result in empty boxes like you say in comment 1.
This needs an exact STR, cross platform testing and regression analysis for me to be able to say much.
What about the extra "#2" camera after replugging per comment 0, is it still around? That's what I consider this bug to be about.
Flags: needinfo?(ovidiu.boca)
Reporter | ||
Comment 16•7 years ago
|
||
The extra "#2" is not reproducible anymore.
But following the same STR that are described in this bug, on Windows, I have the results from comment 1.
I will look to see if this is a regression or not.
Flags: needinfo?(ovidiu.boca)
Reporter | ||
Comment 17•7 years ago
|
||
Tested on FF beta 59.0b14 with https://appear.in and Logitec HD 920 camera.
Results: go to settings after you re-connect the camera, the camera section is greyed out and in the microphone section you have a drop down but no matter what device you choose the video and audio capture is blocked in the same state as when you unplug the camera.
Maybe we should split this in separate bugs?
Assignee | ||
Comment 18•7 years ago
|
||
(In reply to ovidiu boca[:Ovidiu] from comment #17)
> Tested on FF beta 59.0b14 with https://appear.in and Logitec HD 920 camera.
>
> Results: go to settings after you re-connect the camera, the camera section
> is greyed out and in the microphone section you have a drop down but no
> matter what device you choose the video and audio capture is blocked in the
> same state as when you unplug the camera.
>
> Maybe we should split this in separate bugs?
Can you explain how this is a bug on our end?
Flags: needinfo?(ovidiu.boca)
Reporter | ||
Comment 19•7 years ago
|
||
Because I compared this behavior with Chrome and there you can select what device to share and the video is refreshed and you can continue your call, on Firefox you can't continue your call.
Flags: needinfo?(ovidiu.boca)
Assignee | ||
Comment 20•7 years ago
|
||
(In reply to ovidiu boca[:Ovidiu] from comment #19)
> Because I compared this behavior with Chrome and there you can select what
> device to share and the video is refreshed and you can continue your call,
> on Firefox you can't continue your call.
This is because of differences in permission handling of getUserMedia in Chrome vs Firefox.
With websites building specifically for Chrome (where most users are) instead of for all cases covered by the spec we can't expect them to always get it right. (Chrome provides some shortcuts in that it automatically persists the permission given by the user, so most sites assume that once you've got one gUM resolved you can do whatever you want)
From my point of view this issue was resolved by bug 1436959. Marking as such.
Feel free to open a new bug if you have a concrete case where we don't follow the spec. Or perhaps Tech Evangelism issues for the sites that don't work well with Firefox.
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox58:
? → ---
status-firefox59:
? → ---
status-firefox60:
affected → ---
status-firefox-esr52:
? → ---
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•