Closed Bug 1436343 Opened 7 years ago Closed 7 years ago

Small fonts panel css cleanup

Categories

(DevTools :: Inspector, enhancement, P2)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pbro, Assigned: pbro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In bug 1280162 we're adding more features to the font inspector. These features will require more UI to be built in the font inspector. But currently this panel already shows the list of fonts. I think we should prepare the font inspector for this bug change a bit: clean up some of the CSS, and simplify the panel's UI a bit.
This first one is just some cleanup. I have a next one that re-structures a little bit the UI, basically making it a bit more compact. I plan on giving it for review to Victoria before asking for a code review.
Comment on attachment 8949137 [details] Bug 1436343 - Simplified the font inspector's CSS; https://reviewboard.mozilla.org/r/218538/#review224316 Code analysis found 1 defect in this patch: - 1 defect found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: devtools/client/inspector/fonts/components/Font.js:132 (Diff revision 1) > - }, > - " " + getStr("fontinspector.remote") > - ), > - this.renderFontFormatURL(URI, format), > - this.renderFontCSS(CSSFamilyName), > + this.renderFontCSS(CSSFamilyName), > - this.renderFontCSSCode(rule, ruleText) > + rule ? this.renderFontCSSCode(ruleText) : null, Error: Unexpected trailing comma. [eslint: comma-dangle]
Attachment #8949137 - Flags: review?(gl) → review+
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Keywords: leave-open
Pushed by pbrosset@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/79604510fe9a Simplified the font inspector's CSS; r=gl
Let's use a follow up bug for other changes.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Summary: Make the fonts panel UI more compact and ready for more features later. → Small fonts panel css cleanup
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
Product: Firefox → DevTools
Component: Inspector: Fonts → Inspector
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: