Closed
Bug 1436343
Opened 7 years ago
Closed 7 years ago
Small fonts panel css cleanup
Categories
(DevTools :: Inspector, enhancement, P2)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pbro, Assigned: pbro)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
In bug 1280162 we're adding more features to the font inspector.
These features will require more UI to be built in the font inspector. But currently this panel already shows the list of fonts.
I think we should prepare the font inspector for this bug change a bit: clean up some of the CSS, and simplify the panel's UI a bit.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
This first one is just some cleanup. I have a next one that re-structures a little bit the UI, basically making it a bit more compact. I plan on giving it for review to Victoria before asking for a code review.
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8949137 [details]
Bug 1436343 - Simplified the font inspector's CSS;
https://reviewboard.mozilla.org/r/218538/#review224316
Code analysis found 1 defect in this patch:
- 1 defect found by mozlint
You can run this analysis locally with:
- `./mach lint path/to/file` (JS/Python)
If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx
::: devtools/client/inspector/fonts/components/Font.js:132
(Diff revision 1)
> - },
> - " " + getStr("fontinspector.remote")
> - ),
> - this.renderFontFormatURL(URI, format),
> - this.renderFontCSS(CSSFamilyName),
> + this.renderFontCSS(CSSFamilyName),
> - this.renderFontCSSCode(rule, ruleText)
> + rule ? this.renderFontCSSCode(ruleText) : null,
Error: Unexpected trailing comma. [eslint: comma-dangle]
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8949137 [details]
Bug 1436343 - Simplified the font inspector's CSS;
https://reviewboard.mozilla.org/r/218538/#review224328
Attachment #8949137 -
Flags: review?(gl) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Assignee | ||
Updated•7 years ago
|
Keywords: leave-open
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79604510fe9a
Simplified the font inspector's CSS; r=gl
Comment 7•7 years ago
|
||
bugherder |
Assignee | ||
Comment 8•7 years ago
|
||
Here's the latest mockup for this: https://mozilla.invisionapp.com/share/Z3F7OGCTK#/screens/278367863
Assignee | ||
Comment 9•7 years ago
|
||
Let's use a follow up bug for other changes.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Summary: Make the fonts panel UI more compact and ready for more features later. → Small fonts panel css cleanup
Comment 10•7 years ago
|
||
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•4 years ago
|
Component: Inspector: Fonts → Inspector
You need to log in
before you can comment on or make changes to this bug.
Description
•