Closed
Bug 1436908
Opened 7 years ago
Closed 7 years ago
Fix EGLSurface leak at RenderCompositorANGLE
Categories
(Core :: Graphics: WebRender, defect, P1)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
RenderCompositorANGLE::Destroy() is implemented, but it is not called correctly. It seems to better to call DestroyEGLSurface() in RenderCompositorANGLE::~RenderCompositorANGLE() instead.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → sotaro.ikeda.g
|
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Summary: Remove RenderCompositorANGLE::Destroy() → Fix EGLSurface leak at RenderCompositorANGLE
|
|
Assignee | |
Comment 2•7 years ago
|
||
Comment on attachment 8949635 [details] [diff] [review]
patch - Fix EGLSurface leak at RenderCompositorANGLE
The patch actually fixing the leak. Removing Destroy()s are just a side effect.
Attachment #8949635 -
Attachment description: patch - Remove RenderCompositorANGLE::Destroy() → patch - Fix EGLSurface leak at RenderCompositorANGLE
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8949635 -
Flags: review?(nical.bugzilla)
|
|
Assignee | |
Comment 3•7 years ago
|
||
|
||
Updated•7 years ago
|
Attachment #8949635 -
Flags: review?(nical.bugzilla) → review+
|
||
Updated•7 years ago
|
Blocks: stage-wr-nightly
Priority: -- → P1
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/209ac1955df7
Fix EGLSurface leak at RenderCompositorANGLE r=nical
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•