Comment on attachment 8949766 [details] [diff] [review] r16-1.patch Review of attachment 8949766 [details] [diff] [review]: ----------------------------------------------------------------- Clearing the review flag, this doesn't seem ready for review. Some tests seem to be renamed in browser.ini (browser_dbg_keyboard_shortcuts.js -> browser_dbg-keyboard-shortcuts.js) but no actual file move in the patch.

Ah sorry the files have been renamed, it's just that splinter doesn't show them for some reason. Looking at try devtools/client/debugger/new/test/mochitest/browser_dbg-quick-open.js fails on several platforms.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9bf6bde273a796c6bc94abf5a134e4a96383b012 ^ new try run... w/ this fix: https://github.com/devtools-html/debugger.html/pull/5397

alright, the try run is green sans-windows for quick open which i'll disable in the next patch.

Comment on attachment 8950573 [details] [diff] [review] r16-2.patch Review of attachment 8950573 [details] [diff] [review]: ----------------------------------------------------------------- Is there another patch with a bundle update? This doesn't look like a debugger release. If that's really Release 16.0, we should still: - update the README accordingly - create a release branch on GH Otherwise I'm fine with landing this as a "test fix" and not make it a release. In that case, can you update the commit message to something else?

Comment on attachment 8950631 [details] [diff] [review] r16-3.patch Review of attachment 8950631 [details] [diff] [review]: ----------------------------------------------------------------- Looks good Jason, thanks for working on those tests! (nb: In case you want to do the release 16 in another bug, can you rename the bug and unblock the meta?)

Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f699c4a7fa05 Re-enable some debugger mochitests. r=jdescottes