Closed
Bug 1437315
Opened 7 years ago
Closed 7 years ago
Restore the "menuitem-iconic-desc-noaccel" binding after the removal in bug 1418459
Categories
(Thunderbird :: General, enhancement)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 60.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(2 files, 2 obsolete files)
|
(deleted),
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
Bug 1418459 removed the "menuitem-iconic-desc-noaccel" binding. We need it for the description in composer's from menupoup.
|
Assignee | |
Comment 1•7 years ago
|
||
The descriptions are back with this patch.
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8950014 [details] [diff] [review]
menuitem-iconic-desc-noaccel.patch
Yes, this works, thank you.
Attachment #8950014 -
Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/dbaae0514e5e
Restore the "menuitem-iconic-desc-noaccel" binding after the removal in bug 1418459. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
||
Updated•7 years ago
|
Target Milestone: --- → Thunderbird 60.0
This does not seem to work for me on Linux. May some rule be overriding this style?
|
|
Assignee | |
Comment 5•7 years ago
|
||
The code you removed previously needs to be re-added with binding path updated.
Attachment #8950023 -
Flags: review?(acelists)
|
|
||
Updated•7 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 6•7 years ago
|
||
Make the selector more specific in bindings.css.
Attachment #8950023 -
Attachment is obsolete: true
Attachment #8950023 -
Flags: review?(acelists)
Attachment #8950024 -
Flags: review?(acelists)
Comment on attachment 8950024 [details] [diff] [review]
Bug1437315-fup.patch
Review of attachment 8950024 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks, works on Linux.
::: mail/base/content/bindings.css
@@ +27,5 @@
> menulist[type="description"] {
> -moz-binding: url("chrome://messenger/content/mailWidgets.xml#menulist-description");
> }
>
> +menupopup > menuitem[description] {
Semantically it would probably be more correct to do "menulist[type="description"] menuitem[description]" or "menulist[type="description"] > menupopup > menuitem[description]", would that be much slower to be relevant?
Attachment #8950024 -
Flags: review?(acelists) → review+
|
|
Assignee | |
Comment 8•7 years ago
|
||
Made the selector more specific.
Attachment #8950024 -
Attachment is obsolete: true
Attachment #8950051 -
Flags: review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/388dfe87bd6e
Follow-up: Make the menuitem[description] in bindings.css more specific. r=aceman
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
|
|
Assignee | |
Updated•6 years ago
|
Blocks: tb-war-on-xbl
You need to log in
before you can comment on or make changes to this bug.
Description
•