Closed
Bug 1437631
Opened 7 years ago
Closed 6 years ago
Flexbox highlighter doesn't honor RTL or Writing Mode
Categories
(DevTools :: Inspector, defect, P3)
DevTools
Inspector
Tracking
(firefox65 verified)
VERIFIED
FIXED
Firefox 65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | verified |
People
(Reporter: jryans, Assigned: miker)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 1 obsolete file)
Capture.PNG
| Comment hidden (obsolete) |
|
||
Updated•7 years ago
|
Priority: -- → P3
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•6 years ago
|
Component: Framework → Inspector
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
| Comment hidden (obsolete) |
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9015504 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•6 years ago
|
Summary: Flexbox highlighter doesn't work for writing mode / RTL → Flexbox highlighter doesn't work for RTL
|
|
Assignee | |
Updated•6 years ago
|
Summary: Flexbox highlighter doesn't work for RTL → Flexbox highlighter doesn't honor RTL
|
|
Assignee | |
Comment 3•6 years ago
|
||
| str | ||
STR
1. Load the test file.
2. Ensure the flexbox highlighter lines up with all the horizontal flexbox items.
| Comment hidden (obsolete) |
| Comment hidden (obsolete) |
|
|
Assignee | |
Comment 6•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9016362 -
Flags: review?(gl)
|
|
||
Updated•6 years ago
|
Attachment #9016362 -
Flags: review?(gl)
|
|
Assignee | |
Updated•6 years ago
|
Summary: Flexbox highlighter doesn't honor RTL → Flexbox highlighter doesn't honor RTL or Writing Mode
|
||
Updated•6 years ago
|
Attachment #9016362 -
Attachment description: Bug 1437631 - Flexbox highlighter doesn't honor RTL → Bug 1437631 - Flexbox highlighter doesn't honor RTL or writing mode
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f0ea9200122
Flexbox highlighter doesn't honor RTL or writing mode r=gl
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
|
||
Updated•6 years ago
|
status-firefox60:
affected → ---
|
||
Comment 10•6 years ago
|
||
Vertical and Sideway scenarios: When zooming in at 140% parts of the highlighter are not properly displayed anymore, and when the zoom reaches 150% the highlighter shifts. Is this something that can be fixed here, if the issue is reopened or should I open a different issue addressing the zoom issue specifically? I could not repro the issue for the horizontal scenarios.
Flags: needinfo?(mratcliffe)
|
|
Assignee | |
Comment 11•6 years ago
|
||
(In reply to Paul_B from comment #10)
> Created attachment 9021987 [details]
> Capture.PNG
>
> Vertical and Sideway scenarios: When zooming in at 140% parts of the
> highlighter are not properly displayed anymore, and when the zoom reaches
> 150% the highlighter shifts. Is this something that can be fixed here, if
> the issue is reopened or should I open a different issue addressing the zoom
> issue specifically? I could not repro the issue for the horizontal scenarios.
That is a known issue with all of our highlighters... I don't recall the bug number but it is something we plan to work on some time soon.
Flags: needinfo?(mratcliffe)
|
||
Updated•6 years ago
|
Flags: qe-verify+
|
||
Comment 12•6 years ago
|
||
I reproduced this issue using 60.0a1(2018-02-12), on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 65.0b10 on Windows 10 x64, macOS 10.13 and Ubuntu 16.04 LTS.
Cheers!
You need to log in
before you can comment on or make changes to this bug.