Closed Bug 1437728 Opened 7 years ago Closed 7 years ago

toolkit/xre/test/browser_checkcfgstatus.js fails after bug 1193394

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

Wait for a tick before removing tab in BrowserTestUtils.withNewTab.
(deleted), patch
Gijs
: review+
Details | Diff | Splinter Review
https://treeherder.mozilla.org/#/jobs?repo=try&revision=701a987d4fcddd24a4f67f08df6f9ee2b9b81f3a&selectedJob=161720996 > FAIL | toolkit/xre/test/browser_checkcfgstatus.js | Uncaught exception at chrome://browser/content/tabbrowser.xml:4500 - TypeError: initialBrowser.frameLoader.tabParent is null > Stack trace: init@chrome://browser/content/tabbrowser.xml:4500:1 > _getSwitcher@chrome://browser/content/tabbrowser.xml:5352:11 > set_selectedIndex@chrome://browser/content/tabbrowser.xml:8598:11 > set_selectedPanel@chrome://global/content/bindings/tabbox.xml:674:13 > set_selectedIndex@chrome://global/content/bindings/tabbox.xml:392:15 > set_selectedItem@chrome://global/content/bindings/tabbox.xml:424:34 > set_selectedTab@chrome://global/content/bindings/tabbox.xml:100:15 > set_selectedTab@chrome://browser/content/tabbrowser.xml:3958:11 > _blurTab@chrome://browser/content/tabbrowser.xml:3505:32 > _beginRemoveTab@chrome://browser/content/tabbrowser.xml:3219:13 > removeTab@chrome://browser/content/tabbrowser.xml:3123:18 > removeTab@resource://testing-common/BrowserTestUtils.jsm:1111:7 > withNewTab@resource://testing-common/BrowserTestUtils.jsm:107:13 > async*test_cfg_enabled@chrome://mochitests/content/browser/toolkit/xre/test/browser_checkcfgstatus.js:32:9 > Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1067:21 > Tester_execTest@chrome://mochikit/content/browser-test.js:1058:9 > Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:958:9 > SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59 it's too early to remove tab, in BrowserTestUtils.withNewTab it should wait for at least a tick.
uh, I cannot trigger new jobs due to bug 1437738 :P
Added `await TestUtils.waitForTick();` before removing tab, so that even if `taskFn` returns within a tick, the newly opened tab won't be removed in the same tick.
Attachment #8950456 - Flags: review?(gijskruitbosch+bugs)
Attachment #8950456 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/e480e3b7819d Wait for a tick before removing tab in BrowserTestUtils.withNewTab. r=gijs
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e480e3b7819d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: