$ ./obj-firefox-artifact/dist/bin/run-mozilla.sh ./obj-firefox-artifact/dist/bin/xpcshell xpc devtools/server/ Then, manually edited to avoid modifying test_memory_allocations_01.html Review commit: https://reviewboard.mozilla.org/r/220100/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/220100/

All but devtools/server/tests/unit/test_protocol_children.js which really uses generators on purpose. $ ./obj-firefox-artifact/dist/bin/run-mozilla.sh ./obj-firefox-artifact/dist/bin/xpcshell xpc devtools/server/tests/ --replace-generator Review commit: https://reviewboard.mozilla.org/r/220102/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/220102/

Review commit: https://reviewboard.mozilla.org/r/220104/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/220104/

$ find devtools/server/ -type f -exec sed -i 's/async function(/async function (/g' {} \; Review commit: https://reviewboard.mozilla.org/r/220106/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/220106/

Review commit: https://reviewboard.mozilla.org/r/220108/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/220108/

But still import it from test_memory_allocations_01.html. Review commit: https://reviewboard.mozilla.org/r/220110/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/220110/

Review commit: https://reviewboard.mozilla.org/r/220112/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/220112/

Comment on attachment 8950863 [details] Bug 1437828 - Convert Task.jsm to async/await in devtools/server. https://reviewboard.mozilla.org/r/220100/#review225976 Code analysis found 135 defects in this patch (only the first 30 are reported here): - 135 defects found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: devtools/server/actors/inspector/utils.js:194 (Diff revision 1) > * resized: true } > * }. > * > * If something goes wrong, the promise is rejected. > */ > -const imageToImageData = Task.async(function* (node, maxDim) { > +const imageToImageData = async function(node, maxDim) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/performance/recorder.js:316 (Diff revision 1) > * A promise that is resolved once recording has started. > */ > - startRecording: Task.async(function* (options) { > + async startRecording(options) { > let profilerStart, timelineStart, memoryStart; > > - profilerStart = Task.spawn(function* () { > + profilerStart = (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_accessibility_node.js:9 (Diff revision 1) > > "use strict"; > > // Checks for the AccessibleActor > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_accessibility_node_events.js:9 (Diff revision 1) > > "use strict"; > > // Checks for the AccessibleActor events > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_accessibility_simple.js:9 (Diff revision 1) > > "use strict"; > > // Simple checks for the AccessibilityActor and AccessibleWalkerActor > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_emitMutations.js:10 (Diff revision 1) > "use strict"; > > // Test that the AnimationsActor emits events about changed animations on a > // node after getAnimationPlayersForNode was called on that node. > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_getFrames.js:10 (Diff revision 1) > "use strict"; > > // Check that the AnimationPlayerActor exposes a getFrames method that returns > // the list of keyframes in the animation. > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_getMultipleStates.js:10 (Diff revision 1) > "use strict"; > > // Check that the duration, iterationCount and delay are retrieved correctly for > // multiple animations. > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_getPlayers.js:9 (Diff revision 1) > > "use strict"; > > // Check the output of getAnimationPlayersForNode > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_getProperties.js:12 (Diff revision 1) > // Check that the AnimationPlayerActor exposes a getProperties method that > // returns the list of animated properties in the animation. > > const URL = MAIN_DOMAIN + "animation.html"; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_getSubTreeAnimations.js:12 (Diff revision 1) > // Check that the AnimationsActor can retrieve all animations inside a node's > // subtree (but not going into iframes). > > const URL = MAIN_DOMAIN + "animation.html"; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_keepFinished.js:13 (Diff revision 1) > // Test that the AnimationsActor doesn't report finished animations as removed. > // Indeed, animations that only have the "finished" playState can be modified > // still, so we want the AnimationsActor to preserve the corresponding > // AnimationPlayerActor. > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_playPauseIframe.js:12 (Diff revision 1) > // Check that the AnimationsActor can pause/play all animations even those > // within iframes. > > const URL = MAIN_DOMAIN + "animation.html"; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_playPauseSeveral.js:18 (Diff revision 1) > // caused when finite animations are already done playing by the time the test > // runs. > const ALL_ANIMATED_NODES = [".simple-animation", ".multiple-animations", > ".delayed-animation"]; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_reconstructState.js:10 (Diff revision 1) > "use strict"; > > // Check that, even though the AnimationPlayerActor only sends the bits of its > // state that change, the front reconstructs the whole state everytime. > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_refreshTransitions.js:11 (Diff revision 1) > > // When a transition finishes, no "removed" event is sent because it may still > // be used, but when it restarts again (transitions back), then a new > // AnimationPlayerFront should be sent, and the old one should be removed. > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_setCurrentTime.js:10 (Diff revision 1) > "use strict"; > > // Check that a player's currentTime can be changed and that the AnimationsActor > // allows changing many players' currentTimes at once. > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_setPlaybackRate.js:10 (Diff revision 1) > "use strict"; > > // Check that a player's playbackRate can be changed, and that multiple players > // can have their rates changed at the same time. > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_simple.js:9 (Diff revision 1) > > "use strict"; > > // Simple checks for the AnimationsActor > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_layout_getGrids.js:110 (Diff revision 1) > } > ] > } > }; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_layout_simple.js:9 (Diff revision 1) > > "use strict"; > > // Simple checks for the LayoutActor and GridActor > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_markers-cycle-collection.js:12 (Diff revision 1) > */ > "use strict"; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_markers-docloading-03.js:12 (Diff revision 1) > "use strict"; > > const { TimelineFront } = require("devtools/shared/fronts/timeline"); > const MARKER_NAMES = ["document::DOMContentLoaded", "document::Load"]; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_markers-gc.js:12 (Diff revision 1) > "use strict"; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > const MARKER_NAME = "GarbageCollection"; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_markers-parse-html.js:12 (Diff revision 1) > "use strict"; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > const MARKER_NAME = "Parse HTML"; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_perf-allocation-data.js:12 (Diff revision 1) > > "use strict"; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_perf-profiler-01.js:15 (Diff revision 1) > "use strict"; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > const { pmmIsProfilerActive, pmmLoadFrameScripts } = require("devtools/client/performance/test/helpers/profiler-mm-utils"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_perf-profiler-02.js:14 (Diff revision 1) > "use strict"; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > const { pmmIsProfilerActive, pmmLoadFrameScripts } = require("devtools/client/performance/test/helpers/profiler-mm-utils"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_perf-profiler-03.js:16 (Diff revision 1) > "use strict"; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > const { pmmIsProfilerActive, pmmStartProfiler, pmmLoadFrameScripts, pmmClearFrameScripts } = require("devtools/client/performance/test/helpers/profiler-mm-utils"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_perf-realtime-markers.js:12 (Diff revision 1) > > "use strict"; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_perf-recording-actor-01.js:13 (Diff revision 1) > > "use strict"; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_perf-samples-01.js:16 (Diff revision 1) > // time in ms > const WAIT_TIME = 1000; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_perf-samples-02.js:17 (Diff revision 1) > // Time in ms > const WAIT_TIME = 1000; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_cookies-duplicate-names.js:45 (Diff revision 1) > isSecure: false, > } > ] > }; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_cookies-duplicate-names.js:73 (Diff revision 1) > let numHosts = Object.keys(cookiesActor.hosts).length; > is(numHosts, 1, "Correct number of host entries for cookies"); > return testCookiesObjects(0, cookiesActor.hosts, cookiesActor); > } > > -var testCookiesObjects = Task.async(function* (index, hosts, cookiesActor) { > +var testCookiesObjects = async function(index, hosts, cookiesActor) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_dynamic_windows.js:245 (Diff revision 1) > } > }); > }); > } > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_listings.js:351 (Diff revision 1) > is(Object.keys(cookiesActor.hosts).length, 3, > "Correct number of host entries for cookies"); > return testCookiesObjects(0, cookiesActor.hosts, cookiesActor); > } > > -var testCookiesObjects = Task.async(function* (index, hosts, cookiesActor) { > +var testCookiesObjects = async function(index, hosts, cookiesActor) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_listings.js:396 (Diff revision 1) > is(Object.keys(localStorageActor.hosts).length, 3, > "Correct number of host entries for local storage"); > return testLocalStorageObjects(0, localStorageActor.hosts, localStorageActor); > } > > -var testLocalStorageObjects = Task.async(function* (index, hosts, localStorageActor) { > +var testLocalStorageObjects = async function(index, hosts, localStorageActor) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_listings.js:430 (Diff revision 1) > "Correct number of host entries for session storage"); > return testSessionStorageObjects(0, sessionStorageActor.hosts, > sessionStorageActor); > } > > -var testSessionStorageObjects = Task.async(function* (index, hosts, sessionStorageActor) { > +var testSessionStorageObjects = async function(index, hosts, sessionStorageActor) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_listings.js:457 (Diff revision 1) > return; > } > - yield testSessionStorageObjects(++index, hosts, sessionStorageActor); > -}); > + await testSessionStorageObjects(++index, hosts, sessionStorageActor); > +}; > > -var testIndexedDB = Task.async(function* (indexedDBActor) { > +var testIndexedDB = async function(indexedDBActor) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_listings.js:480 (Diff revision 1) > - yield testIndexedDBs(0, indexedDBActor.hosts, indexedDBActor); > - yield testObjectStores(0, indexedDBActor.hosts, indexedDBActor); > - yield testIDBEntries(0, indexedDBActor.hosts, indexedDBActor); > -}); > + await testIndexedDBs(0, indexedDBActor.hosts, indexedDBActor); > + await testObjectStores(0, indexedDBActor.hosts, indexedDBActor); > + await testIDBEntries(0, indexedDBActor.hosts, indexedDBActor); > +}; > > -var testIndexedDBs = Task.async(function* (index, hosts, indexedDBActor) { > +var testIndexedDBs = async function(index, hosts, indexedDBActor) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_listings.js:510 (Diff revision 1) > return; > } > - yield testIndexedDBs(++index, hosts, indexedDBActor); > -}); > + await testIndexedDBs(++index, hosts, indexedDBActor); > +}; > > -var testObjectStores = Task.async(function* (ix, hosts, indexedDBActor) { > +var testObjectStores = async function(ix, hosts, indexedDBActor) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_listings.js:561 (Diff revision 1) > return; > } > - yield testObjectStores(++ix, hosts, indexedDBActor); > -}); > + await testObjectStores(++ix, hosts, indexedDBActor); > +}; > > -var testIDBEntries = Task.async(function* (index, hosts, indexedDBActor) { > +var testIDBEntries = async function(index, hosts, indexedDBActor) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_listings.js:599 (Diff revision 1) > return; > } > - yield testObjectStores(++index, hosts, indexedDBActor); > -}); > + await testObjectStores(++index, hosts, indexedDBActor); > +}; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_updates.js:299 (Diff revision 1) > yield client.close(); > DebuggerServer.destroy(); > finish(); > } > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_stylesheets_getTextEmpty.js:14 (Diff revision 1) > const {StyleSheetsFront} = require("devtools/shared/fronts/stylesheets"); > > const CONTENT = "<style>body { background-color: #f06; }</style>"; > const TEST_URI = "data:text/html;charset=utf-8," + encodeURIComponent(CONTENT); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_stylesheets_nested-iframes.js:12 (Diff revision 1) > // Test that StyleSheetsActor.getStyleSheets() works if an iframe does not have > // a content document. > > const {StyleSheetsFront} = require("devtools/shared/fronts/stylesheets"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_timeline.js:15 (Diff revision 1) > // just that markers are recorded at all. > // Trying to check marker types here may lead to intermittents, see bug 1066474. > > const {TimelineFront} = require("devtools/shared/fronts/timeline"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_timeline_actors.js:13 (Diff revision 1) > // Test that the timeline can also record data from the memory and framerate > // actors, emitted as events in tadem with the markers. > > const {TimelineFront} = require("devtools/shared/fronts/timeline"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_timeline_iframes.js:13 (Diff revision 1) > // Test the timeline front receives markers events for operations that occur in > // iframes. > > const {TimelineFront} = require("devtools/shared/fronts/timeline"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/head.js:38 (Diff revision 1) > * @return a promise that resolves to the new browser that the document > * is loaded in. Note that we cannot return the document > * directly, since this would be a CPOW in the e10s case, > * and Promises cannot be resolved with CPOWs (see bug 1233497). > */ > -var addTab = Task.async(function* (url) { > +var addTab = async function(url) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/storage-helpers.js:20 (Diff revision 1) > */ > -function* openTabAndSetupStorage(url) { > - let content = yield addTab(url); > +async function openTabAndSetupStorage(url) { > + let content = await addTab(url); > > // Setup the async storages in main window and for all its iframes > - yield ContentTask.spawn(gBrowser.selectedBrowser, null, function* () { > + await ContentTask.spawn(gBrowser.selectedBrowser, null, async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/storage-helpers.js:55 (Diff revision 1) > } > }); > } > > -function* clearStorage() { > - yield ContentTask.spawn(gBrowser.selectedBrowser, null, function* () { > +async function clearStorage() { > + await ContentTask.spawn(gBrowser.selectedBrowser, null, async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:24 (Diff revision 1) > }; > > let gWalker = null; > let gDoc = null; > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-pick-color.html:26 (Diff revision 1) > SimpleTest.waitForExplicitFinish(); > > let win = null; > let inspector = null; > > - addAsyncTest(function* () { > + addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory.html:21 (Diff revision 1) > "use strict"; > > window.onload = function () { > SimpleTest.waitForExplicitFinish(); > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory_allocations_02.html:21 (Diff revision 1) > "use strict"; > > window.onload = function () { > SimpleTest.waitForExplicitFinish(); > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory_allocations_03.html:21 (Diff revision 1) > "use strict"; > > window.onload = function () { > SimpleTest.waitForExplicitFinish(); > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory_allocations_04.html:21 (Diff revision 1) > "use strict"; > > window.onload = function () { > SimpleTest.waitForExplicitFinish(); > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory_allocations_04.html:32 (Diff revision 1) > for (let i = 0; i < 100; i++) { > allocs.push({}); > } > } > > - let testProbability = Task.async(function* (p, expected) { > + let testProbability = async function(p, expected) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory_allocations_06.html:21 (Diff revision 1) > "use strict"; > > window.onload = function () { > SimpleTest.waitForExplicitFinish(); > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory_allocations_07.html:21 (Diff revision 1) > "use strict"; > > window.onload = function () { > SimpleTest.waitForExplicitFinish(); > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory_attach_02.html:21 (Diff revision 1) > "use strict"; > > window.onload = function () { > SimpleTest.waitForExplicitFinish(); > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory_census.html:21 (Diff revision 1) > "use strict"; > > window.onload = function () { > SimpleTest.waitForExplicitFinish(); > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory_gc_01.html:35 (Diff revision 1) > o[Math.random()] = 1; > objects.push(o); > } > objects = null; > > - yield { total: beforeGC } = memory.measure(); > + await { total: beforeGC } = memory.measure(); Error: Parsing error: assigning to rvalue [eslint: None] ::: devtools/server/tests/mochitest/test_memory_gc_events.html:23 (Diff revision 1) > window.onload = function () { > SimpleTest.waitForExplicitFinish(); > > let EventEmitter = require("devtools/shared/event-emitter"); > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_websocket-server.html:23 (Diff revision 1) > const WebSocketServer = require("devtools/server/websocket-server"); > > const ServerSocket = CC("@mozilla.org/network/server-socket;1", > "nsIServerSocket", "init"); > > - add_task(function* () { > + add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_MemoryActor_saveHeapSnapshot_01.js:11 (Diff revision 1) > // Test that we can tell the memory actor to take a heap snapshot over the RDP > // and then create a HeapSnapshot instance from the resulting file. > > const { OS } = require("resource://gre/modules/osfile.jsm"); > > -const run_test = makeMemoryActorTest(function* (client, memoryFront) { > +const run_test = makeMemoryActorTest(async function(client, memoryFront) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_MemoryActor_saveHeapSnapshot_03.js:11 (Diff revision 1) > // Test that we can save full runtime heap snapshots when attached to the > // ChromeActor or a ChildProcessActor. > > const { OS } = require("resource://gre/modules/osfile.jsm"); > > -const run_test = makeFullRuntimeMemoryActorTest(function* (client, memoryFront) { > +const run_test = makeFullRuntimeMemoryActorTest(async function(client, memoryFront) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_blackboxing-01.js:31 (Diff revision 1) > } > > const BLACK_BOXED_URL = "http://example.com/blackboxme.js"; > const SOURCE_URL = "http://example.com/source.js"; > > -const testBlackBox = Task.async(function* () { > +const testBlackBox = async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_blackboxing-01.js:125 (Diff revision 1) > 1 > ); > /* eslint-enable */ > } > > -const runTest = Task.async(function* (onSteppedLocation, onDebuggerStatementFrames) { > +const runTest = async function(onSteppedLocation, onDebuggerStatementFrames) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_blackboxing-01.js:144 (Diff revision 1) > onDebuggerStatementFrames(frames); > > return resume(gThreadClient); > -}); > +}; > > -const getCurrentLocation = Task.async(function* () { > +const getCurrentLocation = async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_breakpoint-13.js:43 (Diff revision 1) > function test_simple_breakpoint() { > gThreadClient.addOneTimeListener("paused", function (event, packet) { > let source = gThreadClient.source(packet.frame.where.source); > let location = { line: gDebuggee.line0 + 2 }; > > - source.setBreakpoint(location, Task.async(function* (response, bpClient) { > + source.setBreakpoint(location, async function(response, bpClient) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_breakpoint-14.js:43 (Diff revision 1) > function test_simple_breakpoint() { > gThreadClient.addOneTimeListener("paused", function (event, packet) { > let source = gThreadClient.source(packet.frame.where.source); > let location = { line: gDebuggee.line0 + 2 }; > > - source.setBreakpoint(location, Task.async(function* (response, bpClient) { > + source.setBreakpoint(location, async function(response, bpClient) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_breakpoint-20.js:24 (Diff revision 1) > attachTestThread(gClient, "test-breakpoints", testBreakpoint); > }); > do_test_pending(); > } > > -const testBreakpoint = Task.async(function* (threadResponse, tabClient, > +const testBreakpoint = async function(threadResponse, tabClient, Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_breakpoint-22.js:36 (Diff revision 1) > test(); > }); > }); > } > > -const test = Task.async(function* () { > +const test = async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_listsources-04.js:24 (Diff revision 1) > }); > do_test_pending(); > } > > function run_test_with_server(server, cb) { > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_listsources-04.js:34 (Diff revision 1) > - const [,, threadClient] = yield attachTestTabAndResume(client, "test-sources"); > + const [,, threadClient] = await attachTestTabAndResume(client, "test-sources"); > > - yield threadClient.reconfigure({ useSourceMaps: true }); > + await threadClient.reconfigure({ useSourceMaps: true }); > addSources(debuggee); > > - threadClient.getSources(Task.async(function* (res) { > + threadClient.getSources(async function(res) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_objectgrips-14.js:44 (Diff revision 1) > > debugger; > }); > } > > -const testObjectGroup = Task.async(function* () { > +const testObjectGroup = async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_objectgrips-15.js:42 (Diff revision 1) > > Promise.resolve().then(foo).then(foo); > }); > } > > -const testObjectGroup = Task.async(function* () { > +const testObjectGroup = async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_promise_state-03.js:20 (Diff revision 1) > const client = new DebuggerClient(DebuggerServer.connectPipe()); > client.connect().then(function () { > attachTestTabAndResume( > client, "test-promise-state", > function (response, tabClient, threadClient) { > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_promises_actor_list_promises.js:14 (Diff revision 1) > "use strict"; > > const { PromisesFront } = require("devtools/shared/fronts/promises"); > const SECRET = "MyLittleSecret"; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_promises_actor_onpromisesettled.js:17 (Diff revision 1) > > const { PromisesFront } = require("devtools/shared/fronts/promises"); > > var EventEmitter = require("devtools/shared/event-emitter"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_promises_client_getdependentpromises.js:14 (Diff revision 1) > > const { PromisesFront } = require("devtools/shared/fronts/promises"); > > var EventEmitter = require("devtools/shared/event-emitter"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_promises_object_timetosettle-01.js:15 (Diff revision 1) > > const { PromisesFront } = require("devtools/shared/fronts/promises"); > > var EventEmitter = require("devtools/shared/event-emitter"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_promises_object_timetosettle-02.js:16 (Diff revision 1) > const { PromisesFront } = require("devtools/shared/fronts/promises"); > const { setTimeout } = ChromeUtils.import("resource://gre/modules/Timer.jsm", {}); > > var EventEmitter = require("devtools/shared/event-emitter"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_setBreakpoint-on-column-in-gcd-script.js:6 (Diff revision 1) > "use strict"; > > var SOURCE_URL = getFileUrl("setBreakpoint-on-column-in-gcd-script.js"); > > function run_test() { > - return Task.spawn(function* () { > + return (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_setBreakpoint-on-column.js:6 (Diff revision 1) > "use strict"; > > var SOURCE_URL = getFileUrl("setBreakpoint-on-column.js"); > > function run_test() { > - return Task.spawn(function* () { > + return (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_setBreakpoint-on-line-with-multiple-offsets.js:6 (Diff revision 1) > "use strict"; > > var SOURCE_URL = getFileUrl("setBreakpoint-on-line-with-multiple-offsets.js"); > > function run_test() { > - return Task.spawn(function* () { > + return (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_setBreakpoint-on-line-with-multiple-statements.js:6 (Diff revision 1) > "use strict"; > > var SOURCE_URL = getFileUrl("setBreakpoint-on-line-with-multiple-statements.js"); > > function run_test() { > - return Task.spawn(function* () { > + return (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_setBreakpoint-on-line-with-no-offsets-in-gcd-script.js:6 (Diff revision 1) > "use strict"; > > var SOURCE_URL = getFileUrl("setBreakpoint-on-line-with-no-offsets-in-gcd-script.js"); > > function run_test() { > - return Task.spawn(function* () { > + return (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_setBreakpoint-on-line.js:6 (Diff revision 1) > "use strict"; > > var SOURCE_URL = getFileUrl("setBreakpoint-on-line.js"); > > function run_test() { > - return Task.spawn(function* () { > + return (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_sourcemaps-03.js:31 (Diff revision 1) > }); > do_test_pending(); > } > > function testBreakpointMapping(name, callback) { > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_sourcemaps-16.js:24 (Diff revision 1) > attachTestThread(gClient, "test-sourcemaps", testSourcemap); > }); > do_test_pending(); > } > > -const testSourcemap = Task.async( > +const testSourcemap = async function(threadResponse, tabClient, threadClient, tabResponse) { Error: Line 24 exceeds the maximum line length of 90. [eslint: max-len] ::: devtools/server/tests/unit/test_sourcemaps-16.js:24 (Diff revision 1) > attachTestThread(gClient, "test-sourcemaps", testSourcemap); > }); > do_test_pending(); > } > > -const testSourcemap = Task.async( > +const testSourcemap = async function(threadResponse, tabClient, threadClient, tabResponse) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_sourcemaps-16.js:27 (Diff revision 1) > > -const testSourcemap = Task.async( > +const testSourcemap = async function(threadResponse, tabClient, threadClient, tabResponse) { > - function* (threadResponse, tabClient, threadClient, tabResponse) { > evalTestCode(); > > - const { sources } = yield getSources(threadClient); > + const { sources } = await getSources(threadClient); Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy] ::: devtools/server/tests/unit/test_sourcemaps-16.js:36 (Diff revision 1) > ok(sourceResponse, "Should be able to get the source response"); > ok(sourceResponse.source, "Should have the source text as well"); > } > > finishClient(gClient); > - } > + }; Error: Expected indentation of 0 spaces but found 2. [eslint: indent-legacy] ::: devtools/server/websocket-server.js:83 (Diff revision 1) > > /** > * Read HTTP request from async input stream. > * @return Request line (string) and Map of header names and values. > */ > -const readHttpRequest = Task.async(function* (input) { > +const readHttpRequest = async function(input) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/websocket-server.js:168 (Diff revision 1) > } > > /** > * Perform the server part of a WebSocket opening handshake on an incoming connection. > */ > -const serverHandshake = Task.async(function* (input, output) { > +const serverHandshake = async function(input, output) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/websocket-server.js:196 (Diff revision 1) > * Accept an incoming WebSocket server connection. > * Takes an established nsISocketTransport in the parameters. > * Performs the WebSocket handshake and waits for the WebSocket to open. > * Returns Promise with a WebSocket ready to send and receive messages. > */ > -const accept = Task.async(function* (transport, input, output) { > +const accept = async function(transport, input, output) { Error: Missing space before function parentheses. [eslint: space-before-function-paren]

Comment on attachment 8950864 [details] Bug 1437828 - Convert generators to sync functions in devtools/server/tests https://reviewboard.mozilla.org/r/220102/#review225978 Code analysis found 32 defects in this patch (only the first 30 are reported here): - 32 defects found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:41 (Diff revision 1) > gWalker = await inspector.getWalker(); > > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:55 (Diff revision 1) > > ok(true, "The call to walker.parents() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:69 (Diff revision 1) > > ok(true, "The call to walker.children() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:83 (Diff revision 1) > > ok(true, "The call to walker.siblings() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:97 (Diff revision 1) > > ok(true, "The call to walker.nextSibling() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:111 (Diff revision 1) > > ok(true, "The call to walker.previousSibling() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:126 (Diff revision 1) > > ok(true, "The call to walker.addPseudoClassLock() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:141 (Diff revision 1) > > ok(true, "The call to walker.removePseudoClassLock() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:156 (Diff revision 1) > > ok(true, "The call to walker.clearPseudoClassLocks() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:170 (Diff revision 1) > > ok(true, "The call to walker.innerHTML() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:184 (Diff revision 1) > > ok(true, "The call to walker.setInnerHTML() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:198 (Diff revision 1) > > ok(true, "The call to walker.outerHTML() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:212 (Diff revision 1) > > ok(true, "The call to walker.setOuterHTML() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:228 (Diff revision 1) > > ok(true, "The call to walker.insertAdjacentHTML() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:247 (Diff revision 1) > > ok(hasThrown, "The call to walker.removeNode() threw"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:268 (Diff revision 1) > > ok(hasThrown, "The call to walker.removeNodes() threw"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:284 (Diff revision 1) > > ok(true, "The call to walker.insertBefore() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:301 (Diff revision 1) > > ok(true, "The call to walker.insertBefore() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:315 (Diff revision 1) > > ok(true, "The call to walker.editTagName() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:329 (Diff revision 1) > > ok(true, "The call to walker.hideNode() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:343 (Diff revision 1) > > ok(true, "The call to walker.unhideNode() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:357 (Diff revision 1) > > ok(true, "The call to walker.releaseNode() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-pick-color.html:42 (Diff revision 1) > }); > > runNextTest(); > }); > > - addAsyncTest(function* () { > + addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-pick-color.html:56 (Diff revision 1) > is(color, "#000000", "The color-picked event was received with the right color"); > > runNextTest(); > }); > > - addAsyncTest(function* () { > + addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-pick-color.html:74 (Diff revision 1) > ok(true, "The color-pick-canceled event was received"); > > runNextTest(); > }); > > - addAsyncTest(function* () { > + addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-resize.html:42 (Diff revision 1) > }); > > runNextTest(); > }); > > - addAsyncTest(function* () { > + addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_styles-layout.html:40 (Diff revision 1) > addTest(function () { > ok(gStyles.getLayout, "The PageStyleActor has a getLayout method"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_styles-layout.html:58 (Diff revision 1) > } > > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_styles-layout.html:82 (Diff revision 1) > } > > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/webconsole-helpers.js:41 (Diff revision 1) > */ > async function attachURL(url) { > let win = window.open(url, "_blank"); > let client = null; > > - let cleanup = function* () { > + let cleanup = async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_protocolSpec.js:3 (Diff revision 1) > "use strict"; > > -const run_test = Test(function* () { > +const run_test = Test(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_protocol_formtype.js:144 (Diff revision 1) > form(v, ctx, detail) { > this.lastForm = v; > } > }); > > -const run_test = Test(function* () { > +const run_test = Test(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren]

Comment on attachment 8950866 [details] Bug 1437828 - Put spaces before parentheses in "async function()" pattern. https://reviewboard.mozilla.org/r/220106/#review225998 Code analysis found 1 defect in this patch: - 1 defect found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: devtools/server/tests/unit/test_sourcemaps-16.js:24 (Diff revision 1) > attachTestThread(gClient, "test-sourcemaps", testSourcemap); > }); > do_test_pending(); > } > > -const testSourcemap = async function(threadResponse, tabClient, threadClient, tabResponse) { > +const testSourcemap = async function (threadResponse, tabClient, threadClient, tabResponse) { Error: Line 24 exceeds the maximum line length of 90. [eslint: max-len]

The sandbox used in this test isn't immediately destroyed when the test finishes. So use a unique file name to always refer to the expected sandbox/file in this debugger test. Review commit: https://reviewboard.mozilla.org/r/220258/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/220258/

The breakpoint is set in a function called every second. We have to unregister it before test finishes, otherwise it gets randomly called during test shutdown. Review commit: https://reviewboard.mozilla.org/r/220260/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/220260/

Comment on attachment 8950869 [details] Bug 1437828 - xpcshell script used to convert files, coming from bug 1353542 Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220112/diff/1-2/

Comment on attachment 8950863 [details] Bug 1437828 - Convert Task.jsm to async/await in devtools/server. https://reviewboard.mozilla.org/r/220100/#review226152 Code analysis found 135 defects in this patch (only the first 30 are reported here): - 135 defects found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: devtools/server/actors/inspector/utils.js:194 (Diff revision 1) > * resized: true } > * }. > * > * If something goes wrong, the promise is rejected. > */ > -const imageToImageData = Task.async(function* (node, maxDim) { > +const imageToImageData = async function(node, maxDim) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/actors/stylesheets.js:785 (Diff revision 1) > * > * @return {Promise} > * Promise that resolves to an array of StyleSheetActors > */ > _addStyleSheets: function (win) { > - return Task.spawn(function* () { > + return (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/actors/stylesheets.js:823 (Diff revision 1) > * Style sheet to search > * @return {Promise} > * A promise that resolves with an array of StyleSheetActors > */ > _getImported: function (doc, styleSheet) { > - return Task.spawn(function* () { > + return (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/performance/recorder.js:316 (Diff revision 1) > * A promise that is resolved once recording has started. > */ > - startRecording: Task.async(function* (options) { > + async startRecording(options) { > let profilerStart, timelineStart, memoryStart; > > - profilerStart = Task.spawn(function* () { > + profilerStart = (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_accessibility_node_events.js:9 (Diff revision 1) > > "use strict"; > > // Checks for the AccessibleActor events > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_accessibility_simple.js:9 (Diff revision 1) > > "use strict"; > > // Simple checks for the AccessibilityActor and AccessibleWalkerActor > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_accessibility_walker.js:9 (Diff revision 1) > > "use strict"; > > // Checks for the AccessibleWalkerActor > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_emitMutations.js:10 (Diff revision 1) > "use strict"; > > // Test that the AnimationsActor emits events about changed animations on a > // node after getAnimationPlayersForNode was called on that node. > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_getFrames.js:10 (Diff revision 1) > "use strict"; > > // Check that the AnimationPlayerActor exposes a getFrames method that returns > // the list of keyframes in the animation. > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_getProperties.js:12 (Diff revision 1) > // Check that the AnimationPlayerActor exposes a getProperties method that > // returns the list of animated properties in the animation. > > const URL = MAIN_DOMAIN + "animation.html"; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_getStateAfterFinished.js:14 (Diff revision 1) > // the node has multiple animations and one of them already ended before getting > // the player objects. > // See devtools/server/actors/animation.js |getPlayerIndex| for more > // information. > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_getSubTreeAnimations.js:12 (Diff revision 1) > // Check that the AnimationsActor can retrieve all animations inside a node's > // subtree (but not going into iframes). > > const URL = MAIN_DOMAIN + "animation.html"; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_keepFinished.js:13 (Diff revision 1) > // Test that the AnimationsActor doesn't report finished animations as removed. > // Indeed, animations that only have the "finished" playState can be modified > // still, so we want the AnimationsActor to preserve the corresponding > // AnimationPlayerActor. > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_playerState.js:9 (Diff revision 1) > > "use strict"; > > // Check the animation player's initial state > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_reconstructState.js:10 (Diff revision 1) > "use strict"; > > // Check that, even though the AnimationPlayerActor only sends the bits of its > // state that change, the front reconstructs the whole state everytime. > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_refreshTransitions.js:11 (Diff revision 1) > > // When a transition finishes, no "removed" event is sent because it may still > // be used, but when it restarts again (transitions back), then a new > // AnimationPlayerFront should be sent, and the old one should be removed. > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_setCurrentTime.js:10 (Diff revision 1) > "use strict"; > > // Check that a player's currentTime can be changed and that the AnimationsActor > // allows changing many players' currentTimes at once. > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_animation_simple.js:9 (Diff revision 1) > > "use strict"; > > // Simple checks for the AnimationsActor > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_layout_getGrids.js:110 (Diff revision 1) > } > ] > } > }; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_layout_simple.js:9 (Diff revision 1) > > "use strict"; > > // Simple checks for the LayoutActor and GridActor > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_markers-cycle-collection.js:12 (Diff revision 1) > */ > "use strict"; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_markers-gc.js:12 (Diff revision 1) > "use strict"; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > const MARKER_NAME = "GarbageCollection"; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_markers-minor-gc.js:12 (Diff revision 1) > */ > "use strict"; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_markers-parse-html.js:12 (Diff revision 1) > "use strict"; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > const MARKER_NAME = "Parse HTML"; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_markers-styles.js:12 (Diff revision 1) > "use strict"; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > const MARKER_NAME = "Styles"; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_markers-timestamp.js:14 (Diff revision 1) > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > const { pmmConsoleMethod, pmmLoadFrameScripts, pmmClearFrameScripts } > = require("devtools/client/performance/test/helpers/profiler-mm-utils"); > const MARKER_NAME = "TimeStamp"; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_perf-allocation-data.js:12 (Diff revision 1) > > "use strict"; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_perf-profiler-01.js:15 (Diff revision 1) > "use strict"; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > const { pmmIsProfilerActive, pmmLoadFrameScripts } = require("devtools/client/performance/test/helpers/profiler-mm-utils"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_perf-recording-actor-02.js:15 (Diff revision 1) > var BUFFER_SIZE = 20000; > var config = { bufferSize: BUFFER_SIZE }; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_perf-samples-01.js:16 (Diff revision 1) > // time in ms > const WAIT_TIME = 1000; > > const { PerformanceFront } = require("devtools/shared/fronts/performance"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_cookies-duplicate-names.js:45 (Diff revision 1) > isSecure: false, > } > ] > }; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_cookies-duplicate-names.js:73 (Diff revision 1) > let numHosts = Object.keys(cookiesActor.hosts).length; > is(numHosts, 1, "Correct number of host entries for cookies"); > return testCookiesObjects(0, cookiesActor.hosts, cookiesActor); > } > > -var testCookiesObjects = Task.async(function* (index, hosts, cookiesActor) { > +var testCookiesObjects = async function(index, hosts, cookiesActor) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_listings.js:351 (Diff revision 1) > is(Object.keys(cookiesActor.hosts).length, 3, > "Correct number of host entries for cookies"); > return testCookiesObjects(0, cookiesActor.hosts, cookiesActor); > } > > -var testCookiesObjects = Task.async(function* (index, hosts, cookiesActor) { > +var testCookiesObjects = async function(index, hosts, cookiesActor) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_listings.js:396 (Diff revision 1) > is(Object.keys(localStorageActor.hosts).length, 3, > "Correct number of host entries for local storage"); > return testLocalStorageObjects(0, localStorageActor.hosts, localStorageActor); > } > > -var testLocalStorageObjects = Task.async(function* (index, hosts, localStorageActor) { > +var testLocalStorageObjects = async function(index, hosts, localStorageActor) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_listings.js:430 (Diff revision 1) > "Correct number of host entries for session storage"); > return testSessionStorageObjects(0, sessionStorageActor.hosts, > sessionStorageActor); > } > > -var testSessionStorageObjects = Task.async(function* (index, hosts, sessionStorageActor) { > +var testSessionStorageObjects = async function(index, hosts, sessionStorageActor) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_listings.js:457 (Diff revision 1) > return; > } > - yield testSessionStorageObjects(++index, hosts, sessionStorageActor); > -}); > + await testSessionStorageObjects(++index, hosts, sessionStorageActor); > +}; > > -var testIndexedDB = Task.async(function* (indexedDBActor) { > +var testIndexedDB = async function(indexedDBActor) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_listings.js:480 (Diff revision 1) > - yield testIndexedDBs(0, indexedDBActor.hosts, indexedDBActor); > - yield testObjectStores(0, indexedDBActor.hosts, indexedDBActor); > - yield testIDBEntries(0, indexedDBActor.hosts, indexedDBActor); > -}); > + await testIndexedDBs(0, indexedDBActor.hosts, indexedDBActor); > + await testObjectStores(0, indexedDBActor.hosts, indexedDBActor); > + await testIDBEntries(0, indexedDBActor.hosts, indexedDBActor); > +}; > > -var testIndexedDBs = Task.async(function* (index, hosts, indexedDBActor) { > +var testIndexedDBs = async function(index, hosts, indexedDBActor) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_listings.js:510 (Diff revision 1) > return; > } > - yield testIndexedDBs(++index, hosts, indexedDBActor); > -}); > + await testIndexedDBs(++index, hosts, indexedDBActor); > +}; > > -var testObjectStores = Task.async(function* (ix, hosts, indexedDBActor) { > +var testObjectStores = async function(ix, hosts, indexedDBActor) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_listings.js:561 (Diff revision 1) > return; > } > - yield testObjectStores(++ix, hosts, indexedDBActor); > -}); > + await testObjectStores(++ix, hosts, indexedDBActor); > +}; > > -var testIDBEntries = Task.async(function* (index, hosts, indexedDBActor) { > +var testIDBEntries = async function(index, hosts, indexedDBActor) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_listings.js:599 (Diff revision 1) > return; > } > - yield testObjectStores(++index, hosts, indexedDBActor); > -}); > + await testObjectStores(++index, hosts, indexedDBActor); > +}; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_storage_updates.js:299 (Diff revision 1) > yield client.close(); > DebuggerServer.destroy(); > finish(); > } > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_stylesheets_getTextEmpty.js:14 (Diff revision 1) > const {StyleSheetsFront} = require("devtools/shared/fronts/stylesheets"); > > const CONTENT = "<style>body { background-color: #f06; }</style>"; > const TEST_URI = "data:text/html;charset=utf-8," + encodeURIComponent(CONTENT); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_stylesheets_nested-iframes.js:12 (Diff revision 1) > // Test that StyleSheetsActor.getStyleSheets() works if an iframe does not have > // a content document. > > const {StyleSheetsFront} = require("devtools/shared/fronts/stylesheets"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_timeline.js:15 (Diff revision 1) > // just that markers are recorded at all. > // Trying to check marker types here may lead to intermittents, see bug 1066474. > > const {TimelineFront} = require("devtools/shared/fronts/timeline"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/browser_timeline_actors.js:13 (Diff revision 1) > // Test that the timeline can also record data from the memory and framerate > // actors, emitted as events in tadem with the markers. > > const {TimelineFront} = require("devtools/shared/fronts/timeline"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/head.js:38 (Diff revision 1) > * @return a promise that resolves to the new browser that the document > * is loaded in. Note that we cannot return the document > * directly, since this would be a CPOW in the e10s case, > * and Promises cannot be resolved with CPOWs (see bug 1233497). > */ > -var addTab = Task.async(function* (url) { > +var addTab = async function(url) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/storage-helpers.js:20 (Diff revision 1) > */ > -function* openTabAndSetupStorage(url) { > - let content = yield addTab(url); > +async function openTabAndSetupStorage(url) { > + let content = await addTab(url); > > // Setup the async storages in main window and for all its iframes > - yield ContentTask.spawn(gBrowser.selectedBrowser, null, function* () { > + await ContentTask.spawn(gBrowser.selectedBrowser, null, async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/browser/storage-helpers.js:55 (Diff revision 1) > } > }); > } > > -function* clearStorage() { > - yield ContentTask.spawn(gBrowser.selectedBrowser, null, function* () { > +async function clearStorage() { > + await ContentTask.spawn(gBrowser.selectedBrowser, null, async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_css-properties.html:34 (Diff revision 1) > > function toSortedString(array) { > return JSON.stringify(array.sort()); > } > > - const runCssPropertiesTests = Task.async(function* (url, useActor) { > + const runCssPropertiesTests = async function(url, useActor) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:24 (Diff revision 1) > }; > > let gWalker = null; > let gDoc = null; > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-pick-color.html:26 (Diff revision 1) > SimpleTest.waitForExplicitFinish(); > > let win = null; > let inspector = null; > > - addAsyncTest(function* () { > + addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory_allocations_02.html:21 (Diff revision 1) > "use strict"; > > window.onload = function () { > SimpleTest.waitForExplicitFinish(); > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory_allocations_03.html:21 (Diff revision 1) > "use strict"; > > window.onload = function () { > SimpleTest.waitForExplicitFinish(); > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory_allocations_04.html:21 (Diff revision 1) > "use strict"; > > window.onload = function () { > SimpleTest.waitForExplicitFinish(); > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory_allocations_04.html:32 (Diff revision 1) > for (let i = 0; i < 100; i++) { > allocs.push({}); > } > } > > - let testProbability = Task.async(function* (p, expected) { > + let testProbability = async function(p, expected) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory_allocations_05.html:21 (Diff revision 1) > "use strict"; > > window.onload = function () { > SimpleTest.waitForExplicitFinish(); > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory_allocations_06.html:21 (Diff revision 1) > "use strict"; > > window.onload = function () { > SimpleTest.waitForExplicitFinish(); > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory_allocations_07.html:21 (Diff revision 1) > "use strict"; > > window.onload = function () { > SimpleTest.waitForExplicitFinish(); > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory_attach_01.html:21 (Diff revision 1) > "use strict"; > > window.onload = function () { > SimpleTest.waitForExplicitFinish(); > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_memory_gc_01.html:35 (Diff revision 1) > o[Math.random()] = 1; > objects.push(o); > } > objects = null; > > - yield { total: beforeGC } = memory.measure(); > + await { total: beforeGC } = memory.measure(); Error: Parsing error: assigning to rvalue [eslint: None] ::: devtools/server/tests/mochitest/test_memory_gc_events.html:23 (Diff revision 1) > window.onload = function () { > SimpleTest.waitForExplicitFinish(); > > let EventEmitter = require("devtools/shared/event-emitter"); > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_websocket-server.html:23 (Diff revision 1) > const WebSocketServer = require("devtools/server/websocket-server"); > > const ServerSocket = CC("@mozilla.org/network/server-socket;1", > "nsIServerSocket", "init"); > > - add_task(function* () { > + add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/head_dbg.js:95 (Diff revision 1) > if (!tabForm || !rootForm) { > ok(false, "Could not attach to test tab: " + TEST_GLOBAL_NAME); > return; > } > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/head_dbg.js:133 (Diff revision 1) > if (!form) { > ok(false, "Could not attach to chrome actors"); > return; > } > > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_MemoryActor_saveHeapSnapshot_01.js:11 (Diff revision 1) > // Test that we can tell the memory actor to take a heap snapshot over the RDP > // and then create a HeapSnapshot instance from the resulting file. > > const { OS } = require("resource://gre/modules/osfile.jsm"); > > -const run_test = makeMemoryActorTest(function* (client, memoryFront) { > +const run_test = makeMemoryActorTest(async function(client, memoryFront) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_MemoryActor_saveHeapSnapshot_02.js:11 (Diff revision 1) > // Test that we can properly stream heap snapshot files over the RDP as bulk > // data. > > const { OS } = require("resource://gre/modules/osfile.jsm"); > > -const run_test = makeMemoryActorTest(function* (client, memoryFront) { > +const run_test = makeMemoryActorTest(async function(client, memoryFront) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_MemoryActor_saveHeapSnapshot_03.js:11 (Diff revision 1) > // Test that we can save full runtime heap snapshots when attached to the > // ChromeActor or a ChildProcessActor. > > const { OS } = require("resource://gre/modules/osfile.jsm"); > > -const run_test = makeFullRuntimeMemoryActorTest(function* (client, memoryFront) { > +const run_test = makeFullRuntimeMemoryActorTest(async function(client, memoryFront) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_blackboxing-01.js:31 (Diff revision 1) > } > > const BLACK_BOXED_URL = "http://example.com/blackboxme.js"; > const SOURCE_URL = "http://example.com/source.js"; > > -const testBlackBox = Task.async(function* () { > +const testBlackBox = async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_blackboxing-01.js:125 (Diff revision 1) > 1 > ); > /* eslint-enable */ > } > > -const runTest = Task.async(function* (onSteppedLocation, onDebuggerStatementFrames) { > +const runTest = async function(onSteppedLocation, onDebuggerStatementFrames) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_blackboxing-01.js:144 (Diff revision 1) > onDebuggerStatementFrames(frames); > > return resume(gThreadClient); > -}); > +}; > > -const getCurrentLocation = Task.async(function* () { > +const getCurrentLocation = async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_blackboxing-07.js:32 (Diff revision 1) > } > > const BLACK_BOXED_URL = "http://example.com/black-boxed.min.js"; > const SOURCE_URL = "http://example.com/source.js"; > > -const testBlackBox = Task.async(function* () { > +const testBlackBox = async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_breakpoint-03.js:40 (Diff revision 1) > test_skip_breakpoint(); > }); > }); > } > > -var test_no_skip_breakpoint = Task.async(function* (source, location) { > +var test_no_skip_breakpoint = async function(source, location) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_breakpoint-03.js:51 (Diff revision 1) > Assert.equal(bpClient.location.line, gDebuggee.line0 + 3); > - yield bpClient.remove(); > -}); > + await bpClient.remove(); > +}; > > var test_skip_breakpoint = function () { > - gThreadClient.addOneTimeListener("paused", Task.async(function* (event, packet) { > + gThreadClient.addOneTimeListener("paused", async function(event, packet) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_breakpoint-13.js:43 (Diff revision 1) > function test_simple_breakpoint() { > gThreadClient.addOneTimeListener("paused", function (event, packet) { > let source = gThreadClient.source(packet.frame.where.source); > let location = { line: gDebuggee.line0 + 2 }; > > - source.setBreakpoint(location, Task.async(function* (response, bpClient) { > + source.setBreakpoint(location, async function(response, bpClient) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_breakpoint-14.js:43 (Diff revision 1) > function test_simple_breakpoint() { > gThreadClient.addOneTimeListener("paused", function (event, packet) { > let source = gThreadClient.source(packet.frame.where.source); > let location = { line: gDebuggee.line0 + 2 }; > > - source.setBreakpoint(location, Task.async(function* (response, bpClient) { > + source.setBreakpoint(location, async function(response, bpClient) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_breakpoint-15.js:30 (Diff revision 1) > do_test_pending(); > } > > const SOURCE_URL = "http://example.com/source.js"; > > -const testSameBreakpoint = Task.async(function* () { > +const testSameBreakpoint = async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_breakpoint-21.js:37 (Diff revision 1) > test(); > }); > }); > } > > -const test = Task.async(function* () { > +const test = async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_breakpoint-22.js:36 (Diff revision 1) > test(); > }); > }); > } > > -const test = Task.async(function* () { > +const test = async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_listsources-04.js:24 (Diff revision 1) > }); > do_test_pending(); > } > > function run_test_with_server(server, cb) { > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_listsources-04.js:34 (Diff revision 1) > - const [,, threadClient] = yield attachTestTabAndResume(client, "test-sources"); > + const [,, threadClient] = await attachTestTabAndResume(client, "test-sources"); > > - yield threadClient.reconfigure({ useSourceMaps: true }); > + await threadClient.reconfigure({ useSourceMaps: true }); > addSources(debuggee); > > - threadClient.getSources(Task.async(function* (res) { > + threadClient.getSources(async function(res) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_objectgrips-15.js:42 (Diff revision 1) > > Promise.resolve().then(foo).then(foo); > }); > } > > -const testObjectGroup = Task.async(function* () { > +const testObjectGroup = async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_promises_actor_exist.js:11 (Diff revision 1) > > /** > * Test that the PromisesActor exists in the TabActors and ChromeActors. > */ > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_promises_actor_list_promises.js:14 (Diff revision 1) > "use strict"; > > const { PromisesFront } = require("devtools/shared/fronts/promises"); > const SECRET = "MyLittleSecret"; > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_promises_actor_onnewpromise.js:15 (Diff revision 1) > > const { PromisesFront } = require("devtools/shared/fronts/promises"); > > var EventEmitter = require("devtools/shared/event-emitter"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_promises_actor_onpromisesettled.js:17 (Diff revision 1) > > const { PromisesFront } = require("devtools/shared/fronts/promises"); > > var EventEmitter = require("devtools/shared/event-emitter"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_promises_client_getdependentpromises.js:14 (Diff revision 1) > > const { PromisesFront } = require("devtools/shared/fronts/promises"); > > var EventEmitter = require("devtools/shared/event-emitter"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_promises_object_creationtimestamp.js:17 (Diff revision 1) > var EventEmitter = require("devtools/shared/event-emitter"); > > ChromeUtils.defineModuleGetter(this, "Preferences", > "resource://gre/modules/Preferences.jsm"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_promises_object_timetosettle-01.js:15 (Diff revision 1) > > const { PromisesFront } = require("devtools/shared/fronts/promises"); > > var EventEmitter = require("devtools/shared/event-emitter"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_promises_object_timetosettle-02.js:16 (Diff revision 1) > const { PromisesFront } = require("devtools/shared/fronts/promises"); > const { setTimeout } = ChromeUtils.import("resource://gre/modules/Timer.jsm", {}); > > var EventEmitter = require("devtools/shared/event-emitter"); > > -add_task(function* () { > +add_task(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_setBreakpoint-on-column-in-gcd-script.js:6 (Diff revision 1) > "use strict"; > > var SOURCE_URL = getFileUrl("setBreakpoint-on-column-in-gcd-script.js"); > > function run_test() { > - return Task.spawn(function* () { > + return (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_setBreakpoint-on-column-with-no-offsets-at-end-of-line.js:6 (Diff revision 1) > "use strict"; > > var SOURCE_URL = getFileUrl("setBreakpoint-on-column-with-no-offsets-at-end-of-line.js"); > > function run_test() { > - return Task.spawn(function* () { > + return (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_setBreakpoint-on-column.js:6 (Diff revision 1) > "use strict"; > > var SOURCE_URL = getFileUrl("setBreakpoint-on-column.js"); > > function run_test() { > - return Task.spawn(function* () { > + return (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_setBreakpoint-on-line-in-gcd-script.js:6 (Diff revision 1) > "use strict"; > > var SOURCE_URL = getFileUrl("setBreakpoint-on-line-in-gcd-script.js"); > > function run_test() { > - return Task.spawn(function* () { > + return (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_setBreakpoint-on-line-with-multiple-offsets.js:6 (Diff revision 1) > "use strict"; > > var SOURCE_URL = getFileUrl("setBreakpoint-on-line-with-multiple-offsets.js"); > > function run_test() { > - return Task.spawn(function* () { > + return (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_setBreakpoint-on-line-with-no-offsets.js:6 (Diff revision 1) > "use strict"; > > var SOURCE_URL = getFileUrl("setBreakpoint-on-line-with-no-offsets.js"); > > function run_test() { > - return Task.spawn(function* () { > + return (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_sourcemaps-03.js:31 (Diff revision 1) > }); > do_test_pending(); > } > > function testBreakpointMapping(name, callback) { > - Task.spawn(function* () { > + (async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_sourcemaps-16.js:24 (Diff revision 1) > attachTestThread(gClient, "test-sourcemaps", testSourcemap); > }); > do_test_pending(); > } > > -const testSourcemap = Task.async( > +const testSourcemap = async function(threadResponse, tabClient, threadClient, tabResponse) { Error: Line 24 exceeds the maximum line length of 90. [eslint: max-len] ::: devtools/server/tests/unit/test_sourcemaps-16.js:24 (Diff revision 1) > attachTestThread(gClient, "test-sourcemaps", testSourcemap); > }); > do_test_pending(); > } > > -const testSourcemap = Task.async( > +const testSourcemap = async function(threadResponse, tabClient, threadClient, tabResponse) { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_sourcemaps-16.js:27 (Diff revision 1) > > -const testSourcemap = Task.async( > +const testSourcemap = async function(threadResponse, tabClient, threadClient, tabResponse) { > - function* (threadResponse, tabClient, threadClient, tabResponse) { > evalTestCode(); > > - const { sources } = yield getSources(threadClient); > + const { sources } = await getSources(threadClient); Error: Expected indentation of 2 spaces but found 4. [eslint: indent-legacy] ::: devtools/server/tests/unit/test_sourcemaps-16.js:36 (Diff revision 1) > ok(sourceResponse, "Should be able to get the source response"); > ok(sourceResponse.source, "Should have the source text as well"); > } > > finishClient(gClient); > - } > + }; Error: Expected indentation of 0 spaces but found 2. [eslint: indent-legacy]

Comment on attachment 8950864 [details] Bug 1437828 - Convert generators to sync functions in devtools/server/tests https://reviewboard.mozilla.org/r/220102/#review226156 Code analysis found 32 defects in this patch (only the first 30 are reported here): - 32 defects found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:41 (Diff revision 1) > gWalker = await inspector.getWalker(); > > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:55 (Diff revision 1) > > ok(true, "The call to walker.parents() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:69 (Diff revision 1) > > ok(true, "The call to walker.children() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:83 (Diff revision 1) > > ok(true, "The call to walker.siblings() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:97 (Diff revision 1) > > ok(true, "The call to walker.nextSibling() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:111 (Diff revision 1) > > ok(true, "The call to walker.previousSibling() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:126 (Diff revision 1) > > ok(true, "The call to walker.addPseudoClassLock() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:141 (Diff revision 1) > > ok(true, "The call to walker.removePseudoClassLock() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:156 (Diff revision 1) > > ok(true, "The call to walker.clearPseudoClassLocks() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:170 (Diff revision 1) > > ok(true, "The call to walker.innerHTML() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:184 (Diff revision 1) > > ok(true, "The call to walker.setInnerHTML() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:198 (Diff revision 1) > > ok(true, "The call to walker.outerHTML() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:212 (Diff revision 1) > > ok(true, "The call to walker.setOuterHTML() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:228 (Diff revision 1) > > ok(true, "The call to walker.insertAdjacentHTML() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:247 (Diff revision 1) > > ok(hasThrown, "The call to walker.removeNode() threw"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:268 (Diff revision 1) > > ok(hasThrown, "The call to walker.removeNodes() threw"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:284 (Diff revision 1) > > ok(true, "The call to walker.insertBefore() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:301 (Diff revision 1) > > ok(true, "The call to walker.insertBefore() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:315 (Diff revision 1) > > ok(true, "The call to walker.editTagName() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:329 (Diff revision 1) > > ok(true, "The call to walker.hideNode() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:343 (Diff revision 1) > > ok(true, "The call to walker.unhideNode() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-dead-nodes.html:357 (Diff revision 1) > > ok(true, "The call to walker.releaseNode() didn't fail"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-pick-color.html:42 (Diff revision 1) > }); > > runNextTest(); > }); > > - addAsyncTest(function* () { > + addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-pick-color.html:56 (Diff revision 1) > is(color, "#000000", "The color-picked event was received with the right color"); > > runNextTest(); > }); > > - addAsyncTest(function* () { > + addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-pick-color.html:74 (Diff revision 1) > ok(true, "The color-pick-canceled event was received"); > > runNextTest(); > }); > > - addAsyncTest(function* () { > + addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_inspector-resize.html:42 (Diff revision 1) > }); > > runNextTest(); > }); > > - addAsyncTest(function* () { > + addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_styles-layout.html:40 (Diff revision 1) > addTest(function () { > ok(gStyles.getLayout, "The PageStyleActor has a getLayout method"); > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_styles-layout.html:58 (Diff revision 1) > } > > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/test_styles-layout.html:82 (Diff revision 1) > } > > runNextTest(); > }); > > -addAsyncTest(function* () { > +addAsyncTest(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/mochitest/webconsole-helpers.js:41 (Diff revision 1) > */ > async function attachURL(url) { > let win = window.open(url, "_blank"); > let client = null; > > - let cleanup = function* () { > + let cleanup = async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_protocolSpec.js:3 (Diff revision 1) > "use strict"; > > -const run_test = Test(function* () { > +const run_test = Test(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren] ::: devtools/server/tests/unit/test_protocol_formtype.js:144 (Diff revision 1) > form(v, ctx, detail) { > this.lastForm = v; > } > }); > > -const run_test = Test(function* () { > +const run_test = Test(async function() { Error: Missing space before function parentheses. [eslint: space-before-function-paren]

Comment on attachment 8950866 [details] Bug 1437828 - Put spaces before parentheses in "async function()" pattern. https://reviewboard.mozilla.org/r/220106/#review226176 Code analysis found 1 defect in this patch: - 1 defect found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: devtools/server/tests/unit/test_sourcemaps-16.js:24 (Diff revision 1) > attachTestThread(gClient, "test-sourcemaps", testSourcemap); > }); > do_test_pending(); > } > > -const testSourcemap = async function(threadResponse, tabClient, threadClient, tabResponse) { > +const testSourcemap = async function (threadResponse, tabClient, threadClient, tabResponse) { Error: Line 24 exceeds the maximum line length of 90. [eslint: max-len]

Comment on attachment 8950863 [details] Bug 1437828 - Convert Task.jsm to async/await in devtools/server. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220100/diff/1-2/