We now have a code signing certificate and I was able to create local en-US and l10n de builds. Still some things to sort so nothing for review yet. Might all be outside the source tree.

Signing Windows builds needs some final files from the previous full build steps. So mach build distribution can currently not be used. Untangle it a bit for the en-US build and create a full-package step which also creates the full update mar.. For locale builds "export MOZ_MAKE_COMPLETE_MAR=1" can be used.

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: Clunky update mar generation in shell script needed
Testing completed (on m-c, etc.): 2.53.11b1 pre
Risk to taking this patch (and alternatives if risky): build only trivial
String changes made by this patch: --

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: none but long long long Windows build times.
Testing completed (on m-c, etc.): 2.53.11b1 pre
Risk to taking this patch (and alternatives if risky): Update might not remove old files but we no longer support direct upgrade from versions which still used the removed files. Mostly pre 2.0.
String changes made by this patch: --

Sample shell script I used for building a local test build. Didn't built the symbols with it but no changes doing them. Just an example without error checking. Needs to be cleaned up and adapted for the builder.

Comment on attachment 9256067 [details] [diff] [review]
1438084-fullpackage-253102.patch

[Triage Comment]
Seems to be okay r/a=me

Comment on attachment 9256068 [details] [diff] [review]
1438084-cleanremoved-253102.patch

[Triage Comment]
Seems to be okay r/a=me

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/a95bd461ed3a
Remove really really obsolete entries from removed-files.in. r=IanN

The full-package patch is no longer useful for comm-central so I didn't push it. Update generation was moved to taskcluster only and the stuff we use removed just a few weeks ago a susual without consultation in Bug 1744325. When we eventually com to this comm-central level we need to re-add it in our branches.

The certificate and other parts are either confidential or scripts for the builder only. So consider this bug fixed and if something goes wrong add a follow-up.

Turend out helper.exe wasn't signed properly in l10n builds and the en-US.zip so needed to add some kludges and a new make step for l10n update mar creation.

Copied the mar creation inside MOZ_MAKE_COMPLETE_MAR to a separate step. It is impossible otherwise to sign helper.exe and add it to the update.mar using the normal build files.Could probably call the tools script directly but many variable which are already taken care of in l10n.mk. comm-release step for suite.

createmar-l10n command. mozilla-release step for our branch only.

Comment on attachment 9256281 [details] [diff] [review]
1438084-createmar-cr-253102.patch

[Triage Comment]
Whole packaging process needs to be looked at but r/a=me for the moment

Comment on attachment 9256282 [details] [diff] [review]
1438084-createmar-mr-253102.patch

[Triage Comment]
Whole packaging process needs to be looked at but r/a=me for the moment

Target 2.53.10.2
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/05ae2657b96355c808203f3eb721d959a932c7f4
Remove really really obsolete entries from removed-files.in. r=IanN a=IanN

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/4c664c921dc49ddd68a614f42e1762de280f6775
Add build command for creating en-US package including full update mar. r=IanN a=IanN

https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/6cd6a18aff60d146a66c1aea71dedbfbd4d8aa3a
Add create full l10n update mar command mozilla-part. r=IanN a=IanN

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/dfb3121959b46dbf78fbaa411777979653156a12
Add create full l10n update mar command suite-part. r=IanN a=IanN