Closed
Bug 1438165
Opened 7 years ago
Closed 7 years ago
Incorrect display item arena allocations / deallocations
Categories
(Core :: Web Painting, defect)
Core
Web Painting
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: mikokm, Assigned: mikokm)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
Memory management for different size display items that share a type is handled incorrectly.
Assignee | ||
Updated•7 years ago
|
Group: mozilla-employee-confidential
Comment 1•7 years ago
|
||
[Pretty sure you meant to mark this as a "Security-Sensitive Layout Bug" rather than "Employee-Confidential". Both are hidden, but to different groups. --> Fixing.]
Group: mozilla-employee-confidential → layout-core-security
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8951272 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #1)
> [Pretty sure you meant to mark this as a "Security-Sensitive Layout Bug"
> rather than "Employee-Confidential". Both are hidden, but to different
> groups. --> Fixing.]
I was not completely sure about the security implications of this bug and marked it employee confidential just in case. After examining this further and discussing it with Matt, this is most likely not exploitable at the moment.
Updated•7 years ago
|
Group: layout-core-security
Comment 4•7 years ago
|
||
Comment on attachment 8951272 [details] [diff] [review]
unique-displayitem-types.diff
Review of attachment 8951272 [details] [diff] [review]:
-----------------------------------------------------------------
Please make the assertion in nsDisplayListBuilder::Allocate a MOZ_RELEASE_ASSERT too!
Attachment #8951272 -
Flags: review?(matt.woodrow) → review+
Pushed by mikokm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7faf85adc898
Ensure that all display items have a unique type r=mattwoodrow
Comment 6•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•