Closed Bug 1438531 Opened 7 years ago Closed 7 years ago

Remove leftovers of mocha test from netmonitor

Categories

(DevTools :: Netmonitor, enhancement)

enhancement
Not set
normal

Tracking

(firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file)

One mocha test for netmonitor has been introduced in bug 1309496, but has been removed in bug 1350217. But we still have this test here: https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/test/components/filter-buttons.test.js It appears that this test is left unmaintained and has broken path like: const { configureStore } = require("devtools/client/netmonitor/store"); I saw that while trying to make the console mocha test to work: Cannot find module 'devtools/client/netmonitor/store' --- at: line: 470 column: 15 file: module.js function: Function.Module._resolveFilename stack: > Function._module2.default._resolveFilename (node_modules/require-hacker/babel-transpiled-modules/require hacker.js:423:34) Object.<anonymous> (node_modules/devtools-mc-assets/assets/devtools/client/netmonitor/test/components/filter-buttons.test.js:11:28) We may need to update devtools-mc-assets after that.
Assignee: nobody → poirot.alex
Comment on attachment 8952159 [details] Bug 1438531 - Remove leftovers of mocha test from netmonitor. https://reviewboard.mozilla.org/r/221406/#review227212 Looks reasonable, thanks for the clean up. Honza
Attachment #8952159 - Flags: review?(odvarko) → review+
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/737477b7b0c6 Remove leftovers of mocha test from netmonitor. r=Honza
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: