perfht.ml/2swE6fc

Comment on attachment 8951385 [details] Bug 1438631. Use a similar drawtarget when painting masks. https://reviewboard.mozilla.org/r/220648/#review226614 ::: layout/svg/nsSVGMaskFrame.cpp:91 (Diff revision 1) > - maskDT = gfxPlatform::GetPlatform()->CreateOffscreenContentDrawTarget( > + maskDT = ctx->GetDrawTarget()->CreateSimilarDrawTarget( > maskSurfaceSize, SurfaceFormat::B8G8R8A8); Same question as always: If we're drawing to a non-tiled component alpha layer, will this create a DrawTargetDual? If we paint to a tiled layer, will it create a DrawTargetTiled? I think we resolved this question in a satisfying way at some point but I don't remember what we ended up with.

(In reply to Markus Stange [:mstange] from comment #3) > Comment on attachment 8951385 [details] > Bug 1438631. Use a similar drawtarget when painting masks. > > https://reviewboard.mozilla.org/r/220648/#review226614 > > ::: layout/svg/nsSVGMaskFrame.cpp:91 > (Diff revision 1) > > - maskDT = gfxPlatform::GetPlatform()->CreateOffscreenContentDrawTarget( > > + maskDT = ctx->GetDrawTarget()->CreateSimilarDrawTarget( > > maskSurfaceSize, SurfaceFormat::B8G8R8A8); > > Same question as always: If we're drawing to a non-tiled component alpha > layer, will this create a DrawTargetDual? No > If we paint to a tiled layer, will it create a DrawTargetTiled? No Those are the answers we want in both cases.

This is causing reftest failures with webrender

Looks like the failures are really crashes, and they're perma versions of bug 1437813. We should fix that.

Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3907766823e6 Fix typos in IntoLuminance recording event. https://hg.mozilla.org/integration/mozilla-inbound/rev/2b7d400749d3 Use a similar drawtarget when painting masks. r=mstange

https://hg.mozilla.org/mozilla-central/rev/3907766823e6 https://hg.mozilla.org/mozilla-central/rev/2b7d400749d3