Closed Bug 1438776 Opened 7 years ago Closed 5 years ago

Include keyboard shortcuts into synced extension data

Categories

(Firefox :: Sync, enhancement, P3)

60 Branch
enhancement

Tracking

()

RESOLVED INVALID

People

(Reporter: alexey.v.romanov, Unassigned)

References

(Blocks 1 open bug)

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0 Build ID: 20180112162029 Steps to reproduce: Since there is now a way for an extension to update the shortcut for its command (https://bugzilla.mozilla.org/show_bug.cgi?id=1421811), they should be synchronized (either automatically or explicitly by the extension).
I think that a decision is needed about how we should treat shortcuts in different platform. * Sync only to same platform? * Sync to different platform with auto-migration? For exmaple: Ctrl on Windows => MacCtrl or Command on macOS?
(In reply to YUKI "Piro" Hiroshi from comment #1) > I think that a decision is needed about how we should treat shortcuts in > different platform. > > * Sync only to same platform? > * Sync to different platform with auto-migration? > For exmaple: Ctrl on Windows => MacCtrl or Command on macOS? We also need to decide how to handle the difference between different keyboard layouts. Shortcut keys can be placed somewhere either due to position. For Undo operation: CTRL + Z on a QWERTY keyboard CTRL + W on a AZERTY keyboard CTRL + Y on a QWERTZ keyboard Not to mention that there's variants inside the QWERTY itself between countries. US QUERTY has a dedicated keys for brackets "[]" while the Spanish and Portuguese QWERTY requires the use of AltGr combo. Something should be decided about that. Here are the main elements to think about, for what I can remember. 1: Option to convert between keyboards when synchronizing (use layout instead of the key's meaning)? 2: Option for not synchronize layout-based key bindings (they need to be re-set by the user)? 3: API to register keyboard binds based on layout? 3.1: This API would allow registering a "CTRL+Z" kind of key binding based on the position. 3.2: How to handle overlaps (a key with a meaning on a letter vs a key on a layout position) ----- E.g. Using key "L" because it is near the "Enter" key and having "L" for a "locate" operation clashing together
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Component: Untriaged → Sync
Ever confirmed: true

On v66 Firefox, I can confirm that shortcuts are not synced to Firefox installed on different machines all running Windows. I have configured shortcuts for a few extensions via the new "Manage Extension Shortcuts" page.

Chrome has the same ability to configure shortcuts for extensions, and those do get synced to multiple machines. So maybe look at how Chrome is handling this and adjust accordingly?

Blocks: syncmore
Priority: -- → P3

Extensions should store this using the chrome.storage API, meaning this will sync by default.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID

(In reply to voidpointer from comment #3)

Chrome has the same ability to configure shortcuts for extensions, and those do get synced to multiple machines. So maybe look at how Chrome is handling this and adjust accordingly?

Which extensions did you actually use and confirmed shortcut keys are synced? Mark wrote as:

Extensions should store this using the chrome.storage API, meaning this will sync by default.

and I hope to confirm it is true or not.

You need to log in before you can comment on or make changes to this bug.