Closed
Bug 1438837
Opened 7 years ago
Closed 7 years ago
VirtualizedTree: aria-level should be depth + 1 (according to spec values should be >= 1).
Categories
(DevTools :: Shared Components, defect)
DevTools
Shared Components
Tracking
(firefox60 fixed)
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: MarcoZ, Assigned: yzen)
References
Details
(Keywords: access)
Attachments
(1 file)
(deleted),
patch
|
nchevobbe
:
review+
|
Details | Diff | Splinter Review |
This is with the try build made on Feb 15, 2018.
I use NVDA and Firefox on Windows.
1. Open Accessibility Inspector.
2. Navigate to any element, like a link.
3. Tab to the properties tree. Listen to how NVDA speaks items as being level 1.
4. Navigate down to Actions. NVDA will indicate that it is a closed item, meaning it can be expanded.
5. Press RightArrow to expand.
6. Press DownArrow to move to the revealed child element.
Expected: NVDA should read this and indicate that it is level 2, as this is a child of a parent item, so a level deeper.
Actual: It is still being announced as level 1.
Note that the other tree, the tree of accessible objects, gets this right. Child elements are always 1 level deeper (a number higher) than their parent.
Reporter | ||
Updated•7 years ago
|
Summary: Accessibility Inspector: Child tree items of Actions, Sttes, Attributes etc. have wrong aria-level set. → Accessibility Inspector: Child tree items of Actions, States, Attributes etc. have wrong aria-level set.
Assignee | ||
Updated•7 years ago
|
Summary: Accessibility Inspector: Child tree items of Actions, States, Attributes etc. have wrong aria-level set. → VirtualizedTree: aria-levle should be depth + 1 (according to spec values should be >= 1).
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Assignee | ||
Updated•7 years ago
|
Component: Developer Tools → Developer Tools: Accessibility Tools
Summary: VirtualizedTree: aria-levle should be depth + 1 (according to spec values should be >= 1). → VirtualizedTree: aria-level should be depth + 1 (according to spec values should be >= 1).
Assignee | ||
Updated•7 years ago
|
Component: Developer Tools: Accessibility Tools → Developer Tools: Shared Components
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8953597 -
Flags: review?(nchevobbe)
Comment 2•7 years ago
|
||
Comment on attachment 8953597 [details] [diff] [review]
1438837 patch
Review of attachment 8953597 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me without the CSS change :)
::: devtools/client/shared/components/reps/reps.css
@@ +292,5 @@
> }
>
> /* For non expandable root nodes, we don't have .tree-indent elements, so we declare
> the margin on the start of the node */
> +.tree-node[data-expandable="false"][aria-level="1"] {
I don't think this is wanted: this file should not be used by the VirtualizedTree, and its source of truth is on Github.
Attachment #8953597 -
Flags: review?(nchevobbe) → review+
Comment 3•7 years ago
|
||
I filed https://github.com/devtools-html/devtools-core/issues/963 to do this on the Tree used by the console and the debugger
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d02fd1a8e0ea
fix VirtualizedTree node aria-level attribute to start with 1 not 0. r=nchevobbe
Comment 5•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•