Closed Bug 1438870 Opened 7 years ago Closed 7 years ago

When handling new selection, check if the reason for new selection is related to a keyboard interaction. If so focus on the tree container.

Categories

(DevTools :: Inspector, defect)

Product:
DevTools
Component:
Inspector
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox60 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: MarcoZ, Assigned: yzen)

References

Details

(Keywords: access)

Attachments

(1 file)

1438870 patch
(deleted), patch
gl
: review+
Details | Diff | Splinter Review 
To reproduce this, please use the Feb 15, 2018 try build from bug 1151468 and enable the Accessibility Developer tool.

STR:
1. After done the above, right-click on any item on a page and select Inspect Accessibility.
2. Shift-tab, then tab again (bug 1418835) to get keyboard focus into the tree of properties.
3. DownArrow to DOM Node.
4. Press Enter.

Expected: Inspector opens, keyboard focus is on the selected corresponding HTML node.

Actual: Inspector opens, but keyboard focus is on the panel itself, and I have to press Tab 4 or 5 times to get to the desired tree and position within it.

The expected behavior would be just like when selecting Inspect Element from a page element's context menu, that it drops you right into the tree where the HTML node is highlighted.
Component: Developer Tools: Inspector → Developer Tools: Accessibility Tools
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Component: Developer Tools: Accessibility Tools → Developer Tools: Inspector
Summary: When pressing Enter on the DOM Node property of an Accessibility object, keyboard focus should land on the corresponding node in the HTML inspector. → When handling new selection, check if the reason for new selection is related to a keyboard interaction. If so focus on the tree container.
Attached patch 1438870 patch (deleted) — — Splinter Review 
I know you mentioned the reactification of the markup view, but this would really help with out keyboard/screen reader interaction.
Attachment #8953575 - Flags: review?(gl)
Attachment #8953575 - Flags: review?(gl) → review+
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a60fe594955b
add a check for keyboard action when new selection is handled in markup view. r=gl
https://hg.mozilla.org/mozilla-central/rev/a60fe594955b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: