Closed
Bug 1438953
Opened 7 years ago
Closed 7 years ago
Timer Precision Tests need a more generous float fuzziness value
Categories
(Core :: DOM: Events, enhancement, P2)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
Details
Attachments
(1 file)
Currently in the resist fingerprinting/reduce timer precision tests we have an allowance of ~.0000001 (milliseconds) to account for JAVASCRIPT (not the C++ calculations) fuzziness in float calculations.
When we are working with milliseconds since the epoch, a double's precision is around .0002; so we need to up our epsilon, or face the possibility of intermittents.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•7 years ago
|
||
See https://bugzilla.mozilla.org/show_bug.cgi?id=1430841#c42 for something that should probably be addressed here.
|
||
Updated•7 years ago
|
Priority: -- → P2
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8951713 [details]
Bug 1438953 Increase the epsilon on timer reduction tests
https://reviewboard.mozilla.org/r/220996/#review227238
This seems reasonable. Only shame is that we can't (or haven't yet) pull this out into common code.
::: commit-message-f191f:9
(Diff revision 1)
> +numbers, where doubles can represent very precise decimals. They don't work for large numbers
> +where doubles cannot represent such small decimals.
This seems like an awkward way to express the idea that large doubles can't have precise fractional parts. WDYT about rewording this?
Attachment #8951713 -
Flags: review?(nfroyd) → review+
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by aciure@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5db4200c90a8
Increase the epsilon on timer reduction tests r=froydnj
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
Backed out for failing mochitest at browser/components/resistfingerprinting/test/mochitest/test_animation_api.html
Push that contains the failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d32d276d2917d39471d8aa45192436f8819c5df0
failure log: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d32d276d2917d39471d8aa45192436f8819c5df0
Backout: https://hg.mozilla.org/integration/autoland/rev/ad3678a2943b860a240de123dc57520cf622572c
Flags: needinfo?(tom)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 8•7 years ago
|
||
Okay, fixed the false positive case!
Flags: needinfo?(tom)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5eeff2b96802
Increase the epsilon on timer reduction tests r=froydnj
Keywords: checkin-needed
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•