I would like to get a rid of android_stub.h from moz.build for nss. When not including android_stub.h, we cannot build nss on android/x86. (Other platforms have no this issue.) 21:09.05 /mozilla/mobile-x86/security/nss/lib/freebl/verified/Hacl_Curve25519.c:190:5: error: use of undeclared identifier 'SIZE_MAX' 21:09.05 KRML_CHECK_SIZE(FStar_UInt128_uint64_to_uint128((uint64_t)0U), (uint32_t)5U); 21:09.05 ^ 21:09.05 /mozilla/mobile-x86/security/nss/lib/freebl/verified/kremlib.h:76:26: note: expanded from macro 'KRML_CHECK_SIZE' 21:09.05 if (((size_t)size) > SIZE_MAX / sizeof(elt)) { \ 21:09.05 ^

Comment on attachment 8951983 [details] [diff] [review] Include limits.h to resolve SIZE_MAX on Android/x86 Review of attachment 8951983 [details] [diff] [review]: ----------------------------------------------------------------- Clearing for now. I'm fine with this but we have to wait for https://github.com/FStarLang/kremlin/pull/81 to make it's way to HACL* and then uplift a new revision of HACL*. We can't touch this file.

upstream doesn't seem to be mater, so I will file new PR as https://github.com/FStarLang/kremlin/pull/82 for fstar-master.

Comment on attachment 8951983 [details] [diff] [review] Include limits.h to resolve SIZE_MAX on Android/x86 merged into master (and fstar-master)

Comment on attachment 8951983 [details] [diff] [review] Include limits.h to resolve SIZE_MAX on Android/x86 Review of attachment 8951983 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch! Clearing, not because it's wrong, but because we need to update the revision of HACL* we use as well. I put up a patch on phab.

Comment on attachment 8955047 [details] Bug 1439226 - update HACL*, r=ttaubert Tim Taubert [:ttaubert] has approved the revision. https://phabricator.services.mozilla.com/D662