Closed Bug 1439365 Opened 7 years ago Closed 7 years ago

Add a MinGW Opt Build

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tor])

Attachments

(1 file)

Tor's MinGW build uses --enable-optimize, so it'd be good to actually build that particular configuration.
Comment on attachment 8952123 [details] Bug 1439365 Add a MinGW Opt Build https://reviewboard.mozilla.org/r/221358/#review227300 ::: browser/config/mozconfigs/win32/mingw32-debug:4 (Diff revision 1) > +. "$topsrcdir/browser/config/mozconfigs/win32/mingw32" > + > +ac_add_options --enable-debug > +ac_add_options --disable-optimize I hadn't realized these builds were without optimizations. The other debug builds *are* optimized, are you sure you want these not to be? ::: taskcluster/ci/build/windows.yml:648 (Diff revision 1) > + description: "Win32 MinGW Opt" > + index: > + product: firefox > + job-name: win32-mingw32-opt > + treeherder: > + platform: windows-mingw32-32/opt platforms with one job contribute to making treeherder horrible to watch at. This feels like we should use the same "platform" for mingw32 opt and debug builds.
Attachment #8952123 - Flags: review?(mh+mozilla) → review+
(In reply to Mike Hommey [:glandium] from comment #3) > Comment on attachment 8952123 [details] > Bug 1439365 Add a MinGW Opt Build > > https://reviewboard.mozilla.org/r/221358/#review227300 > > ::: browser/config/mozconfigs/win32/mingw32-debug:4 > (Diff revision 1) > > +. "$topsrcdir/browser/config/mozconfigs/win32/mingw32" > > + > > +ac_add_options --enable-debug > > +ac_add_options --disable-optimize > > I hadn't realized these builds were without optimizations. The other debug > builds *are* optimized, are you sure you want these not to be? Yea, it's tough enough to debug MinGW builds as it is, optimizing them makes it even harder. No one's running these for none-testing/debugging purposes.
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Flags: needinfo?(tom)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: