Closed Bug 1439474 Opened 7 years ago Closed 7 years ago

Make double-free crashes more identifiable

Categories

(Core :: Memory Allocator, enhancement)

Product:
Core
Component:
Memory Allocator
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox-esr52 --- wontfix
firefox58 --- wontfix
firefox59 --- ?
firefox60 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Bug 1439474 - Make double-free crashes more identifiable.
(deleted), text/x-review-board-request
n.nethercote
: review+
Details
No description provided.
Comment on attachment 8952280 [details] Bug 1439474 - Make double-free crashes more identifiable. https://reviewboard.mozilla.org/r/221530/#review227334
Attachment #8952280 - Flags: review?(n.nethercote) → review+
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/7f2dd59744eb Make double-free crashes more identifiable. r=njn
https://hg.mozilla.org/mozilla-central/rev/7f2dd59744eb
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
glandium, should we uplift these release assertions to Beta 59? The original MOZ_DIAGNOSTIC_ASSERTs are already enabled in Nightly and DevEdition builds, so this change won't catch any new double-free bugs until Nightly 60 rides to Beta on March 12.
status-firefox58: --- → wontfix
status-firefox59: --- → ?
status-firefox-esr52: --- → wontfix
Flags: needinfo?(mh+mozilla)
As you mention, the MOZ_RELEASE_ASSERTs replacing the MOZ_DIAGNOSTIC_ASSERTs are not going to catch anything new. The other one is not going to catch anything new either: the rb.h code already crashes when it happens.
Flags: needinfo?(mh+mozilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: