Filed by: ccoroiu [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=163104348&repo=mozilla-central https://queue.taskcluster.net/v1/task/C26sgtRMQYKxC4We1F6OCw/runs/0/artifacts/public/logs/live_backing.log

Over the last 7 days this bug has 34 failures. All of them happen on linux64-jsdcov. Here is the most recent log example: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=164238525&lineNumber=2431 Here is a relevant snippet from that log: [task 2018-02-25T22:37:24.314Z] 22:37:24 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bug495058.js | about:blank: browser is focused - {} == [object XULElement] - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug495058.js :: <TOP_LEVEL> :: line 33 [task 2018-02-25T22:37:24.314Z] 22:37:24 INFO - Stack trace: [task 2018-02-25T22:37:24.314Z] 22:37:24 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug495058.js:null:33 [task 2018-02-25T22:37:24.315Z] 22:37:24 INFO - TEST-PASS | browser/base/content/test/general/browser_bug495058.js | about:blank: urlbar is empty - "" == "" - [task 2018-02-25T22:37:24.315Z] 22:37:24 INFO - TEST-PASS | browser/base/content/test/general/browser_bug495058.js | about:blank: placeholder text is present - "Search or enter address" == true - [task 2018-02-25T22:37:24.477Z] 22:37:24 INFO - TEST-PASS | browser/base/content/test/general/browser_bug495058.js | about:sessionrestore: uri loaded in detached tab - "about:sessionrestore" == "about:sessionrestore" - [task 2018-02-25T22:37:24.477Z] 22:37:24 INFO - Not taking screenshot here: see the one that was previously logged [task 2018-02-25T22:37:24.478Z] 22:37:24 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bug495058.js | about:sessionrestore: browser is focused - {} == [object XULElement] - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug495058.js :: <TOP_LEVEL> :: line 33 [task 2018-02-25T22:37:24.478Z] 22:37:24 INFO - Stack trace: [task 2018-02-25T22:37:24.478Z] 22:37:24 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug495058.js:null:33 [task 2018-02-25T22:37:24.478Z] 22:37:24 INFO - TEST-PASS | browser/base/content/test/general/browser_bug495058.js | about:sessionrestore: urlbar is empty - "" == "" - [task 2018-02-25T22:37:24.478Z] 22:37:24 INFO - TEST-PASS | browser/base/content/test/general/browser_bug495058.js | about:sessionrestore: placeholder text is present - "Search or enter address" == true - [task 2018-02-25T22:37:24.884Z] 22:37:24 INFO - TEST-PASS | browser/base/content/test/general/browser_bug495058.js | about:privatebrowsing: uri loaded in detached tab - "about:privatebrowsing" == "about:privatebrowsing" - [task 2018-02-25T22:37:24.885Z] 22:37:24 INFO - Not taking screenshot here: see the one that was previously logged [task 2018-02-25T22:37:24.885Z] 22:37:24 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bug495058.js | about:privatebrowsing: browser is focused - {} == [object XULElement] - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug495058.js :: <TOP_LEVEL> :: line 33

Hey Mike, since you have worked on this test in the past, maybe there is someone on your team that could look into this?

keep in mind this is only failing when we collect JS coverage via devtools debugger- I suspect this is ok to disable for that config.

There are 54 failures in the past 7 days, all seems to happen on linux64-jsdcov opt. Recent log failure: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=167161009&lineNumber=2603 Relevant part of the log: [task 2018-03-10T11:01:14.294Z] 11:01:14 INFO - Buffered messages finished [task 2018-03-10T11:01:14.294Z] 11:01:14 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bug495058.js | about:blank: browser is focused - {} == [object XULElement] - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug495058.js :: <TOP_LEVEL> :: line 33 [task 2018-03-10T11:01:14.294Z] 11:01:14 INFO - Stack trace: [task 2018-03-10T11:01:14.295Z] 11:01:14 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug495058.js:null:33 [task 2018-03-10T11:01:14.295Z] 11:01:14 INFO - TEST-PASS | browser/base/content/test/general/browser_bug495058.js | about:blank: urlbar is empty - "" == "" - [task 2018-03-10T11:01:14.296Z] 11:01:14 INFO - TEST-PASS | browser/base/content/test/general/browser_bug495058.js | about:blank: placeholder text is present - "Search or enter address" == true - [task 2018-03-10T11:01:14.377Z] 11:01:14 INFO - TEST-PASS | browser/base/content/test/general/browser_bug495058.js | about:sessionrestore: uri loaded in detached tab - "about:sessionrestore" == "about:sessionrestore" - [task 2018-03-10T11:01:14.379Z] 11:01:14 INFO - TEST-PASS | browser/base/content/test/general/browser_bug495058.js | about:sessionrestore: browser is focused - [object XULElement] == [object XULElement] - [task 2018-03-10T11:01:14.379Z] 11:01:14 INFO - TEST-PASS | browser/base/content/test/general/browser_bug495058.js | about:sessionrestore: urlbar is empty - "" == "" - [task 2018-03-10T11:01:14.381Z] 11:01:14 INFO - TEST-PASS | browser/base/content/test/general/browser_bug495058.js | about:sessionrestore: placeholder text is present - "Search or enter address" == true - [task 2018-03-10T11:01:14.739Z] 11:01:14 INFO - TEST-PASS | browser/base/content/test/general/browser_bug495058.js | about:privatebrowsing: uri loaded in detached tab - "about:privatebrowsing" == "about:privatebrowsing" - [task 2018-03-10T11:01:14.740Z] 11:01:14 INFO - Not taking screenshot here: see the one that was previously logged [task 2018-03-10T11:01:14.740Z] 11:01:14 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bug495058.js | about:privatebrowsing: browser is focused - {} == [object XULElement] - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug495058.js :: <TOP_LEVEL> :: line 33 [task 2018-03-10T11:01:14.740Z] 11:01:14 INFO - Stack trace: [task 2018-03-10T11:01:14.740Z] 11:01:14 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug495058.js:null:33 [task 2018-03-10T11:01:14.741Z] 11:01:14 INFO - TEST-PASS | browser/base/content/test/general/browser_bug495058.js | about:privatebrowsing: urlbar is empty - "" == "" - [task 2018-03-10T11:01:14.742Z] 11:01:14 INFO - TEST-PASS | browser/base/content/test/general/browser_bug495058.js | about:privatebrowsing: placeholder text is present - "Search or enter address" == true - [task 2018-03-10T11:01:14.789Z] 11:01:14 INFO - Leaving test bound Can someone please look at this?

Comment on attachment 8958020 [details] [diff] [review] Disabled on Linux jsdcov platform Review of attachment 8958020 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/test/general/browser.ini @@ +162,4 @@ > [browser_bug491431.js] > # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD. > [browser_bug495058.js] > +skip-if = (os == "linux" && jsdcov) # Bug 1439493 we only run jsdcov on linux, so all that is needed is: skip-if = jsdcov # Bug 1439493

(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #4) > keep in mind this is only failing when we collect JS coverage via devtools > debugger- I suspect this is ok to disable for that config. Agreed, but it makes me wonder whether someone on Patrick's team may be a better fit to look at this then.

Hmm, I'm really not sure who would know about this. I think it makes sense to disable the test as suggested here. I have no idea what in the debugger API does the code coverage bit. And how it could make this test fail. But maybe Jim does know.

I'm not familiar with the coverage stuff, but I ought to get familiar with it. I'll see if I can reproduce this.

Updated the patch with skip-if = jsdcov

Pushed by aiakab@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c611e124f515 disabling browser_bug495058.js on Linux jsdcov r=jmaher

:jmaher This is still failing on Linux jsdcov opt. Could you please take a look if we need to modify the patch?

:sparky- I thought we had a way to specify |skip-if = jsdcov|, but I cannot find prior art in the source tree. Do you have more background here that I am forgetting about? Given that we skip so many tests as these run in !e10s, I am considering pushing harder to investigate JSVM data vs jsdcov and turn off jsdcov.

It's coverage not jsdcov: https://dxr.mozilla.org/mozilla-central/search?q=mozinfo+coverage&redirect=false We still haven't had the chance to change the jsdcov flag from 'coverage' to 'jsdcov'.

Arthur, can you redo the patch to use |skip-if = coverage|, here is some prior art: https://searchfox.org/mozilla-central/source/devtools/client/aboutdebugging/test/browser.ini#25

I have modified the patch.

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/64ea6814aefa Disable browser_bug495058.js on Linux jsdcov (coverage). r=jmaher

The linux64-jsdcov build has been disabled, and no longer runs in taskcluster, see bug 1496791.