Closed
Bug 1439517
Opened 7 years ago
Closed 7 years ago
generic-worker: support taskcluster-proxy
Categories
(Taskcluster :: Workers, enhancement)
Taskcluster
Workers
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pmoore, Assigned: pmoore)
References
Details
Attachments
(1 file)
This will reduce the need for many workarounds that are currently in place.
Assignee | ||
Updated•7 years ago
|
QA Contact: pmoore
Assignee | ||
Comment 1•7 years ago
|
||
I've started work on this - not complete yet. Work will go in this PR, and I'll add a comment here when it is ready for review.
Assignee: nobody → pmoore
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•7 years ago
|
||
Just about ready now. There is a unit test which is passing, but I'll add an integration test tomorrow.
Assignee | ||
Comment 3•7 years ago
|
||
Ah - and I'll need to handle credential updates during task execution - so still a bit of work to do. Credentials can get updated while the task is running, which we'll need to handle. There is a taskcluster-proxy endpoint for handling this, so it shouldn't be too tricky.
Assignee | ||
Comment 4•7 years ago
|
||
This is done now - although I don't have a test which explicitly checks that the credentials PUT updates work - just because that would involve a bunch of mocking or customising the reclaim timings so a test could reclaim more quickly than waiting 20 mins.
Oh, I guess I should do that, just to be safe... I'll do that shortly.
Aside from testing the credentials PUT update to /credentials works against taskcluster-proxy, the rest is implemented and has tests.
Assignee | ||
Comment 5•7 years ago
|
||
OK, I think I'm done - just waiting for tests to run.
Assignee | ||
Comment 6•7 years ago
|
||
I'll fix the tests on Monday morning - nothing serious, just some roles need to be updated, and some PATH settings...
Assignee | ||
Comment 7•7 years ago
|
||
Oh, and a data race... Shouldn't be too much work to fix.
Assignee | ||
Updated•7 years ago
|
Attachment #8953103 -
Flags: review?(jhford)
Assignee | ||
Comment 8•7 years ago
|
||
The issues are resolved now, and the tests are all passing.
Comment 9•7 years ago
|
||
Commits pushed to master at https://github.com/taskcluster/generic-worker
https://github.com/taskcluster/generic-worker/commit/01a8e465fb28f158f5d4de27fde3ad4b5397e8e7
Bug 1439517 - add support for taskcluster-proxy
https://github.com/taskcluster/generic-worker/commit/6da7e9b5225a8b77d8e192aca6f04c19f258f3ad
Merge pull request #74 from taskcluster/bug1439517
Bug 1439517 - add support for taskcluster-proxy
Assignee | ||
Comment 10•7 years ago
|
||
Deployed in bug 1399401.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Attachment #8953103 -
Flags: review?(jhford) → review+
Assignee | ||
Comment 11•6 years ago
|
||
Updated•6 years ago
|
Component: Generic-Worker → Workers
You need to log in
before you can comment on or make changes to this bug.
Description
•